Page MenuHomePhabricator

Fix EOF handling in AdbClient (take 2)
ClosedPublic

Authored by labath on May 4 2016, 6:13 AM.

Details

Summary

AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading
the requested number of bytes. Make sure we return an error in this case instead.

Diff Detail

Event Timeline

labath updated this revision to Diff 56134.May 4 2016, 6:13 AM
labath retitled this revision from to Fix EOF handling in AdbClient (take 2).
labath updated this object.
labath added a reviewer: ovyalov.
labath added a subscriber: lldb-commits.
ovyalov accepted this revision.May 4 2016, 8:43 AM
ovyalov edited edge metadata.

LGTM

This revision is now accepted and ready to land.May 4 2016, 8:43 AM
This revision was automatically updated to reflect the committed changes.