Differential D19916

Fix EOF handling in AdbClient (take 2)
ClosedPublic
Actions

Authored by labath on May 4 2016, 6:13 AM.

Details

Reviewers

Commits

rGc14e8ced85ec: Fix EOF handling in AdbClient (take 2)
rLLDB268617: Fix EOF handling in AdbClient (take 2)
rL268617: Fix EOF handling in AdbClient (take 2)

Summary

AdbClient would spin in a loop in ReadAllBytes in case the remote end was closed before reading
the requested number of bytes. Make sure we return an error in this case instead.

Diff Detail

Repository: rL LLVM

Event Timeline

labath updated this revision to Diff 56134.May 4 2016, 6:13 AM

labath retitled this revision from to Fix EOF handling in AdbClient (take 2).

labath updated this object.

labath added a reviewer: ovyalov.

labath added a subscriber: lldb-commits.

Herald added subscribers: danalbert, tberghammer. · View Herald TranscriptMay 4 2016, 6:13 AM

LGTM

This revision is now accepted and ready to land.May 4 2016, 8:43 AM

Closed by commit rL268617: Fix EOF handling in AdbClient (take 2) (authored by labath). · Explain WhyMay 5 2016, 1:48 AM

This revision was automatically updated to reflect the committed changes.

labath mentioned this in D19214: fix a race is the LLDB test suite results collection.May 5 2016, 2:54 AM

Revision Contents
Changeset List

Path

Size

lldb/

trunk/

source/

Plugins/

Platform/

Android/

AdbClient.cpp

23 lines

Diff 56246

View Options

lldb/trunk/source/Plugins/Platform/Android/AdbClient.cpp

Fix EOF handling in AdbClient (take 2)ClosedPublicActions