Page MenuHomePhabricator

Fix for 32 bit platforms.

Authored by chaoren on Apr 29 2016, 4:39 PM.

Diff Detail


Event Timeline

chaoren retitled this revision from to Fix for 32 bit platforms..
chaoren updated this object.
chaoren added a reviewer: clayborg.
chaoren added a subscriber: lldb-commits.
clayborg accepted this revision.Apr 29 2016, 4:40 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.

Chaoren: Did this completely fix the test for you? It's still failing for me on Windows, but for a reason not addressed here.

We don't test host-only Windows. It's passing Windows to Android though.
What's the reason that it fails on Windows?

The test expects expr *f.op to fail because f is a null pointer, but on Windows it yields (ops) $2 = 0. I suspect this is a latent expression evaluation bug exposed by the new test, as it also happens for other types of pointers and not just pointers to enums.