Page MenuHomePhabricator

Use absolute module path when possible if sent in svr4 packets
ClosedPublic

Authored by fjricci on Apr 26 2016, 1:35 PM.

Details

Summary

If the remote uses svr4 packets to communicate library info,
the LoadUnload tests will fail, as lldb only used the basename
for modules, causing problems when two modules have the same basename.

Using absolute path as sent by the remote will ensure that lldb
locates the module from the correct directory when there are overlapping
basenames. When debugging a remote process, LoadModuleAtAddress will still
fall back to using basename and module_search_paths, so we don't
need to worry about using absolute paths in this case.

Diff Detail

Repository
rL LLVM

Event Timeline

fjricci updated this revision to Diff 55083.Apr 26 2016, 1:35 PM
fjricci retitled this revision from to Use absolute module path when possible if sent in svr4 packets.
fjricci updated this object.
fjricci added subscribers: sas, lldb-commits.
clayborg accepted this revision.Apr 26 2016, 2:40 PM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2016, 2:40 PM
ovyalov accepted this revision.Apr 26 2016, 2:44 PM
ovyalov edited edge metadata.

LGTM

This revision was automatically updated to reflect the committed changes.