Remove assert mandating you can only use SPIR target with OpenCL

[sheredom]

Summary

Remove an assert mandating that OpenCL must be used with the SPIR target. We need to be able to use the SPIR target with non-OpenCL inputs, which worked perfectly well until commit 264241 introduced an assert that requires OpenCL be set in LangOpts.

[yaxunl]

LGTM

[Anastasia]

LGTM, just wondering other languages will compile to SPIR too?

[pxli168]

LGTM.

[sheredom]

So we build a bunch of internal libraries in a mix of OpenCL and C++, and then link them all together to create SPIR libraries that can be fed to calls to clLinkProgram and linked against user kernels.

I don't have commit rights to Clang - if the patch is ok to go could one of you bring the patch in for me?

[Anastasia]

Committed in r267561!

[sheredom]

Thanks!

lib/CodeGen/TargetInfo.cpp

public:
   void emitTargetMD(const Decl *D, llvm::GlobalValue *GV,
                     CodeGen::CodeGenModule &M) const override;
 };
 } // End anonymous namespace.
 
 /// Emit SPIR specific metadata: OpenCL and SPIR version.
 void SPIRTargetCodeGenInfo::emitTargetMD(const Decl *D, llvm::GlobalValue *GV,
                                          CodeGen::CodeGenModule &CGM) const {
-  assert(CGM.getLangOpts().OpenCL && "SPIR is only for OpenCL");
   llvm::LLVMContext &Ctx = CGM.getModule().getContext();
   llvm::Type *Int32Ty = llvm::Type::getInt32Ty(Ctx);
   llvm::Module &M = CGM.getModule();
   // SPIR v2.0 s2.12 - The SPIR version used by the module is stored in the
   // opencl.spir.version named metadata.
   llvm::Metadata *SPIRVerElts[] = {
       llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(Int32Ty, 2)),
       llvm::ConstantAsMetadata::get(llvm::ConstantInt::get(Int32Ty, 0))};