Page MenuHomePhabricator

post-commit patch review for r265547
ClosedPublic

Authored by wmi on Apr 9 2016, 11:01 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

wmi updated this revision to Diff 53144.Apr 9 2016, 11:01 AM
wmi retitled this revision from to post-commit patch review for r265547.
wmi updated this object.
wmi added a reviewer: qcolombet.
wmi set the repository for this revision to rL LLVM.
wmi added subscribers: llvm-commits, davidxl.
qcolombet added inline comments.Apr 11 2016, 10:37 AM
lib/CodeGen/InlineSpiller.cpp
1276

Since we make sure not to create an entry for Child, I believe it is safe to SpillsInSubTreeMap[*RIt] in a local variable.
That should make the code a but more readable.

wmi added inline comments.Apr 11 2016, 3:35 PM
lib/CodeGen/InlineSpiller.cpp
1276

Will fix it in the next commit.

qcolombet accepted this revision.Apr 15 2016, 3:28 PM
qcolombet edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2016, 3:28 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Settled in r266162.