Page MenuHomePhabricator

[CUDA] Tweak math forward declares so we're compatible with libstdc++4.9.
ClosedPublic

Authored by jlebar on Apr 7 2016, 4:55 PM.

Details

Summary

See comments in patch; we were assuming that some stdlib math functions
would be defined in namespace std, when in fact the spec says they
should be defined in the global namespace. libstdc++4.9 became more
conforming and broke us.

This new implementation seems to cover the known knowns.

Event Timeline

jlebar updated this revision to Diff 52979.Apr 7 2016, 4:55 PM
jlebar retitled this revision from to [CUDA] Tweak math forward declares so we're compatible with libstdc++4.9..
jlebar updated this object.
jlebar added a reviewer: rsmith.
jlebar added subscribers: tra, cfe-commits.
rsmith accepted this revision.Apr 7 2016, 5:00 PM
rsmith edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2016, 5:00 PM
This revision was automatically updated to reflect the committed changes.
jlebar added a comment.Apr 7 2016, 5:01 PM

Thank you for the review!