This is an archive of the discontinued LLVM Phabricator instance.

Add parentheses around `&&` within `||` to avoid compiler warning message.
ClosedPublic

Authored by hokein on Apr 5 2016, 1:48 AM.

Diff Detail

Event Timeline

hokein updated this revision to Diff 52665.Apr 5 2016, 1:48 AM
hokein retitled this revision from to Add parentheses around `&&` withn `||` to avoid compiler wanring messages..
hokein updated this object.
hokein retitled this revision from Add parentheses around `&&` withn `||` to avoid compiler wanring messages. to Add parentheses around `&&` within `||` to avoid compiler warning message..Apr 5 2016, 1:50 AM
hokein added a reviewer: bkramer.
hokein set the repository for this revision to rL LLVM.
hokein added a subscriber: tejohnson.
bkramer requested changes to this revision.Apr 5 2016, 1:53 AM
bkramer edited edge metadata.

It doesn't make a difference semantically (a string literal is always 'true'), but I'd prefer to have the parentheses around the || here.

This revision now requires changes to proceed.Apr 5 2016, 1:53 AM
hokein updated this revision to Diff 52667.Apr 5 2016, 1:58 AM
hokein edited edge metadata.

Update.

hokein added a comment.Apr 5 2016, 1:58 AM

It doesn't make a difference semantically (a string literal is always 'true'), but I'd prefer to have the parentheses around the || here.

Done.

bkramer accepted this revision.Apr 5 2016, 1:58 AM
bkramer edited edge metadata.

looks good, thanks!

This revision is now accepted and ready to land.Apr 5 2016, 1:58 AM
This revision was automatically updated to reflect the committed changes.

Thanks!
Teresa