This is an archive of the discontinued LLVM Phabricator instance.

Fixing PR26558: the adc builtins do not require the adx target attribute
ClosedPublic

Authored by ygao on Mar 28 2016, 5:07 PM.

Download Raw Diff

Details

Reviewers: None
Commits: rG333e69d70fff: Fixing PR26558: remove the adx target attribute requirement from adc builtins.
rC264801: Fixing PR26558: remove the adx target attribute requirement from adc builtins.
rL264801: Fixing PR26558: remove the adx target attribute requirement from adc builtins.

Summary

Hi,
The addcarry and subborrow variants of the builtins do not require the adx target attribute. Only the addcarryx variants require them.
This patch attempts to remove the target attribute requirements from these builtins, and also to update the test (run the same test without adx and make sure nothing breaks).
Could you review?

Many thanks,

Diff Detail

Event Timeline

ygao updated this revision to Diff 51857.Mar 28 2016, 5:07 PM

ygao retitled this revision from to Fixing PR26558: the adc builtins do not require the adx target attribute.

ygao updated this object.

ygao added subscribers: craig.topper, bogner, cfe-commits.

Closed by commit rL264801: Fixing PR26558: remove the adx target attribute requirement from adc builtins. (authored by ygao). · Explain WhyMar 29 2016, 4:04 PM

This revision was automatically updated to reflect the committed changes.

Yep, only the ADCX instruction needs adx. This LGTM, but please just
remove "-target-feature +adx" from the run line instead of adding a
second run line.

Thanks, Justin.
Committed r264801 and updated the test as you suggested.

Revision Contents

Path

Size

include/

clang/

Basic/

BuiltinsX86.def

8 lines

test/

CodeGen/

adc-builtins.c

1 line

Diff 51857

include/clang/Basic/BuiltinsX86.def

Context not available.
	// ADX	// ADX
	TARGET_BUILTIN(__builtin_ia32_addcarryx_u32, "UcUcUiUiUi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_addcarryx_u32, "UcUcUiUiUi*", "", "adx")
	TARGET_BUILTIN(__builtin_ia32_addcarryx_u64, "UcUcULLiULLiULLi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_addcarryx_u64, "UcUcULLiULLiULLi*", "", "adx")
	TARGET_BUILTIN(__builtin_ia32_addcarry_u32, "UcUcUiUiUi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_addcarry_u32, "UcUcUiUiUi*", "", "")
	TARGET_BUILTIN(__builtin_ia32_addcarry_u64, "UcUcULLiULLiULLi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_addcarry_u64, "UcUcULLiULLiULLi*", "", "")
	TARGET_BUILTIN(__builtin_ia32_subborrow_u32, "UcUcUiUiUi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_subborrow_u32, "UcUcUiUiUi*", "", "")
	TARGET_BUILTIN(__builtin_ia32_subborrow_u64, "UcUcULLiULLiULLi*", "", "adx")	TARGET_BUILTIN(__builtin_ia32_subborrow_u64, "UcUcULLiULLiULLi*", "", "")

	// RDSEED	// RDSEED
	TARGET_BUILTIN(__builtin_ia32_rdseed16_step, "UiUs*", "", "rdseed")	TARGET_BUILTIN(__builtin_ia32_rdseed16_step, "UiUs*", "", "rdseed")
Context not available.

test/CodeGen/adc-builtins.c

	// RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-feature +adx -emit-llvm -o - %s \| FileCheck %s			// RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-feature +adx -emit-llvm -o - %s \| FileCheck %s
				// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o - %s \| FileCheck %s

	#define __MM_MALLOC_H			#define __MM_MALLOC_H