Page MenuHomePhabricator

Fixing PR26558: the adc builtins do not require the adx target attribute
ClosedPublic

Authored by ygao on Mar 28 2016, 5:07 PM.

Details

Summary

Hi,
The addcarry and subborrow variants of the builtins do not require the adx target attribute. Only the addcarryx variants require them.
This patch attempts to remove the target attribute requirements from these builtins, and also to update the test (run the same test without adx and make sure nothing breaks).
Could you review?

Many thanks,

  • Gao

Diff Detail

Repository
rL LLVM

Event Timeline

ygao updated this revision to Diff 51857.Mar 28 2016, 5:07 PM
ygao retitled this revision from to Fixing PR26558: the adc builtins do not require the adx target attribute.
ygao updated this object.
ygao added subscribers: craig.topper, bogner, cfe-commits.
This revision was automatically updated to reflect the committed changes.
ygao added a comment.Mar 29 2016, 4:05 PM

Yep, only the ADCX instruction needs adx. This LGTM, but please just
remove "-target-feature +adx" from the run line instead of adding a
second run line.

Thanks, Justin.
Committed r264801 and updated the test as you suggested.