Page MenuHomePhabricator

[ThinLTO] Use bulk importing in llvm-link
ClosedPublic

Authored by tejohnson on Mar 24 2016, 11:30 AM.

Details

Summary

Along with bulk importing we can avoid the use of post-pass metadata
linking.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson updated this revision to Diff 51575.Mar 24 2016, 11:30 AM
tejohnson retitled this revision from to [ThinLTO] Use bulk importing in llvm-link.
tejohnson updated this object.
tejohnson added a reviewer: mehdi_amini.
tejohnson added subscribers: llvm-commits, dexonsmith.
mehdi_amini accepted this revision.Mar 24 2016, 11:43 AM
mehdi_amini edited edge metadata.

LGTM.
See inline comments.

tools/llvm-link/llvm-link.cpp
130 ↗(On Diff #51575)

It can be used with the FunctionImporter

The function importer is not involved here right? Comment may be updated.

259 ↗(On Diff #51575)

Do we actually want bulk import for llvm-link? Maybe doing one import at a time is a "feature", since it not testing the same thing.
It's probably good for now...

This revision is now accepted and ready to land.Mar 24 2016, 11:43 AM
tejohnson added inline comments.Mar 24 2016, 12:42 PM
tools/llvm-link/llvm-link.cpp
130 ↗(On Diff #51575)

Will fix. This was pretty much just cloned with minor tweaks to the arguments from what is in the function importer pass, since we want to do the same thing here.

259 ↗(On Diff #51575)

Yes, we do need to do the bulk importing to get the metadata importing to work as expected without post-pass metadata linking.

This revision was automatically updated to reflect the committed changes.