This is an archive of the discontinued LLVM Phabricator instance.

Differential D18392

clang-cl: Don't warn about /Oy- being unused in 64-bit builds.
ClosedPublic

Authored by thakis on Mar 23 2016, 5:58 AM.

Details

Reviewers
hans
rnk

Diff Detail

Event Timeline

thakis updated this revision to Diff 51405.Mar 23 2016, 5:58 AM
thakis retitled this revision from to clang-cl: Don't warn about /Oy- being unused in 64-bit builds..
thakis updated this object.
thakis added reviewers: hans, rnk.
thakis added a subscriber: cfe-commits.
hans accepted this revision.Mar 23 2016, 8:11 AM
hans edited edge metadata.

lgtm, thanks!

This revision is now accepted and ready to land.Mar 23 2016, 8:11 AM
thakis closed this revision.Mar 23 2016, 8:43 AM

r264163, thanks!

Revision Contents

PathSize
lib/
Driver/
6 lines
test/
Driver/
6 lines

Diff 51405

lib/Driver/MSVCToolChain.cpp

Show First 20 Lines • Show All 696 Lines • ▼ Show 20 Lines case 'y': {
} }
if (SupportsForcingFramePointer) { if (SupportsForcingFramePointer) {
if (OmitFramePointer) if (OmitFramePointer)
DAL.AddFlagArg(A, DAL.AddFlagArg(A,
Opts.getOption(options::OPT_fomit_frame_pointer)); Opts.getOption(options::OPT_fomit_frame_pointer));
else else
DAL.AddFlagArg( DAL.AddFlagArg(
A, Opts.getOption(options::OPT_fno_omit_frame_pointer)); A, Opts.getOption(options::OPT_fno_omit_frame_pointer));
} else {
// Don't warn about /Oy- in 64-bit builds (where
// SupportsForcingFramePointer is false). The flag having no effect
// there is a compiler-internal optimization, and people shouldn't have
// to special-case their build files for 64-bit clang-cl.
A->claim();
} }
break; break;
} }
} }
} }
} }
static void TranslateDArg(Arg *A, llvm::opt::DerivedArgList &DAL, static void TranslateDArg(Arg *A, llvm::opt::DerivedArgList &DAL,
▲ Show 20 Lines • Show All 60 Lines • Show Last 20 Lines

test/Driver/cl-options.c

Show First 20 Lines • Show All 117 Lines • ▼ Show 20 Lines
// Ox: -momit-leaf-frame-pointer // Ox: -momit-leaf-frame-pointer
// Ox: -O2 // Ox: -O2
// RUN: %clang_cl --target=i686-pc-win32 /O2sy- -### -- %s 2>&1 | FileCheck -check-prefix=PR24003 %s // RUN: %clang_cl --target=i686-pc-win32 /O2sy- -### -- %s 2>&1 | FileCheck -check-prefix=PR24003 %s
// PR24003: -mdisable-fp-elim // PR24003: -mdisable-fp-elim
// PR24003: -momit-leaf-frame-pointer // PR24003: -momit-leaf-frame-pointer
// PR24003: -Os // PR24003: -Os
// RUN: %clang_cl --target=i686-pc-win32 /Oy- /O2 -### -- %s 2>&1 | FileCheck -check-prefix=Oy_2 %s // RUN: %clang_cl --target=i686-pc-win32 -Werror /Oy- /O2 -### -- %s 2>&1 | FileCheck -check-prefix=Oy_2 %s
// Oy_2: -momit-leaf-frame-pointer // Oy_2: -momit-leaf-frame-pointer
// Oy_2: -O2 // Oy_2: -O2
// RUN: %clang_cl /Zs /Oy -- %s 2>&1 // RUN: %clang_cl /Zs -Werror /Oy -- %s 2>&1
// RUN: %clang_cl --target=i686-pc-win32 /Oy- -### -- %s 2>&1 | FileCheck -check-prefix=Oy_ %s // RUN: %clang_cl --target=i686-pc-win32 -Werror /Oy- -### -- %s 2>&1 | FileCheck -check-prefix=Oy_ %s
// Oy_: -mdisable-fp-elim // Oy_: -mdisable-fp-elim
// RUN: %clang_cl /Qvec -### -- %s 2>&1 | FileCheck -check-prefix=Qvec %s // RUN: %clang_cl /Qvec -### -- %s 2>&1 | FileCheck -check-prefix=Qvec %s
// Qvec: -vectorize-loops // Qvec: -vectorize-loops
// RUN: %clang_cl /Qvec /Qvec- -### -- %s 2>&1 | FileCheck -check-prefix=Qvec_ %s // RUN: %clang_cl /Qvec /Qvec- -### -- %s 2>&1 | FileCheck -check-prefix=Qvec_ %s
// Qvec_-NOT: -vectorize-loops // Qvec_-NOT: -vectorize-loops
▲ Show 20 Lines • Show All 316 Lines • Show Last 20 Lines