Page MenuHomePhabricator

[tsan] Allow -fsanitize=thread for iOS-style simulator targets
ClosedPublic

Authored by dcoughlin on Mar 18 2016, 1:59 PM.

Details

Summary

This patch updates the clang driver to allow -fsanitize=thread when targeting x86_64 iOS and tvOS simulators. It also restricts TSan targeting OS X to only be supported on x86_64 and not i386.

Diff Detail

Repository
rL LLVM

Event Timeline

dcoughlin updated this revision to Diff 51066.Mar 18 2016, 1:59 PM
dcoughlin retitled this revision from to [tsan] Allow -fsanitize=thread for iOS-style simulator targets.
dcoughlin updated this object.
dcoughlin added reviewers: samsonov, kubamracek.
dcoughlin added a subscriber: llvm-commits.
dcoughlin edited subscribers, added: cfe-commits; removed: llvm-commits.

There is a related patch for compiler-rt at http://reviews.llvm.org/D18277

samsonov edited edge metadata.Mar 18 2016, 2:03 PM

Cool, great to see this coming. I'll let Kuba sign this off.

test/Driver/fsanitize.c
220 ↗(On Diff #51066)

Care to add a test for ios or tvos?

kubamracek edited edge metadata.Mar 18 2016, 2:46 PM

LGTM after adding a check for a simulator.

dcoughlin updated this revision to Diff 51076.Mar 18 2016, 2:52 PM
dcoughlin edited edge metadata.

Added tests for iOS and iOS simulators.

This revision was automatically updated to reflect the committed changes.