This is an archive of the discontinued LLVM Phabricator instance.

Differential D18253

[AMDGPU] Switch linker to amdphdrs + update test
ClosedPublic

Authored by • kzhuravl-AMD on Mar 17 2016, 2:29 PM.

Details

Reviewers
• tstellarAMD
Commits
rG656871124e98: [AMDGPU] Switch linker to amdphdrs + update test
rC264737: [AMDGPU] Switch linker to amdphdrs + update test
rL264737: [AMDGPU] Switch linker to amdphdrs + update test

Diff Detail

Event Timeline

• kzhuravl-AMD updated this revision to Diff 50975.Mar 17 2016, 2:29 PM
• kzhuravl-AMD retitled this revision from to Switch AMDGPU Linker to amdphdrs + update test.
• kzhuravl-AMD updated this object.
• kzhuravl-AMD added a reviewer: • tstellarAMD.
• kzhuravl-AMD added a subscriber: cfe-commits.
• tstellarAMD accepted this revision.Mar 18 2016, 8:02 AM
• tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Mar 18 2016, 8:02 AM
• kzhuravl-AMD retitled this revision from Switch AMDGPU Linker to amdphdrs + update test to [AMDGPU] Switch linker to amdphdrs + update test.Mar 29 2016, 8:34 AM
• kzhuravl-AMD edited edge metadata.
Closed by commit rL264737: [AMDGPU] Switch linker to amdphdrs + update test (authored by kzhuravl). · Explain WhyMar 29 2016, 8:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Driver/
2 lines
1 line
test/
Driver/
2 lines

Diff 50975

lib/Driver/Tools.h

Show First 20 Lines • Show All 234 Lines • ▼ Show 20 Lines void ConstructJob(Compilation &C, const JobAction &JA,
const char *LinkingOutput) const override; const char *LinkingOutput) const override;
}; };
} // end namespace hexagon. } // end namespace hexagon.
namespace amdgpu { namespace amdgpu {
class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool { class LLVM_LIBRARY_VISIBILITY Linker : public GnuTool {
public: public:
Linker(const ToolChain &TC) : GnuTool("amdgpu::Linker", "ld.lld", TC) {} Linker(const ToolChain &TC) : GnuTool("amdgpu::Linker", "amdphdrs", TC) {}
bool isLinkJob() const override { return true; } bool isLinkJob() const override { return true; }
bool hasIntegratedCPP() const override { return false; } bool hasIntegratedCPP() const override { return false; }
void ConstructJob(Compilation &C, const JobAction &JA, void ConstructJob(Compilation &C, const JobAction &JA,
const InputInfo &Output, const InputInfoList &Inputs, const InputInfo &Output, const InputInfoList &Inputs,
const llvm::opt::ArgList &TCArgs, const llvm::opt::ArgList &TCArgs,
const char *LinkingOutput) const override; const char *LinkingOutput) const override;
}; };
▲ Show 20 Lines • Show All 694 Lines • Show Last 20 Lines

lib/Driver/Tools.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,719 Lines • ▼ Show 20 Linesvoid amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA,
const InputInfo &Output, const InputInfo &Output,
const InputInfoList &Inputs, const InputInfoList &Inputs,
const ArgList &Args, const ArgList &Args,
const char *LinkingOutput) const { const char *LinkingOutput) const {
std::string Linker = getToolChain().GetProgramPath(getShortName()); std::string Linker = getToolChain().GetProgramPath(getShortName());
ArgStringList CmdArgs; ArgStringList CmdArgs;
AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs); AddLinkerInputs(getToolChain(), Inputs, Args, CmdArgs);
CmdArgs.push_back("-o");
CmdArgs.push_back(Output.getFilename()); CmdArgs.push_back(Output.getFilename());
C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Linker), C.addCommand(llvm::make_unique<Command>(JA, *this, Args.MakeArgString(Linker),
CmdArgs, Inputs)); CmdArgs, Inputs));
} }
// AMDGPU tools end. // AMDGPU tools end.
wasm::Linker::Linker(const ToolChain &TC) wasm::Linker::Linker(const ToolChain &TC)
: GnuTool("wasm::Linker", "lld", TC) {} : GnuTool("wasm::Linker", "lld", TC) {}
▲ Show 20 Lines • Show All 4,256 Lines • Show Last 20 Lines

test/Driver/amdgpu-toolchain.c

// RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s // RUN: %clang -### -target amdgcn--amdhsa -x assembler -mcpu=kaveri %s 2>&1 | FileCheck -check-prefix=AS_LINK %s
// AS_LINK: clang{{.*}} "-cc1as" // AS_LINK: clang{{.*}} "-cc1as"
// AS_LINK: ld.lld{{.*}} // AS_LINK: amdphdrs{{.*}}