Page MenuHomePhabricator

[UBSan] Fix test cast-overflow.cc for mips64 big-endian.
AbandonedPublic

Authored by slthakur on Mar 16 2016, 5:16 AM.

Details

Reviewers
samsonov
rsmith
Summary

Gcc for mips does not define BIG_ENDIAN. This causes getFloatValue to return the value of data from 32-bit LSB instead of MSB. Using macro __MIPSEB which is defined by gcc fixes the test cast_overflow.cc.

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 50817.Mar 16 2016, 5:16 AM
slthakur retitled this revision from to [UBSan] Fix test cast-overflow.cc for mips64 big-endian..
slthakur updated this object.
slthakur added reviewers: rsmith, samsonov.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: mohit.bhakkad, jaydeep.
samsonov requested changes to this revision.Mar 16 2016, 11:59 AM
samsonov edited edge metadata.

This was fixed recently, please update.

This revision now requires changes to proceed.Mar 16 2016, 11:59 AM
slthakur abandoned this revision.Mar 17 2016, 11:03 PM

Test passes with the recent fix. Thanks!