This is an archive of the discontinued LLVM Phabricator instance.

Initialize two variables in kmp_tasking.
ClosedPublic

Authored by sfantao on Mar 5 2016, 11:03 AM.

Download Raw Diff

Details

Reviewers

jlpeyton
tlwilmar

Commits

rG11e4c539f473: Initialize two variables in kmp_tasking.
rOMP263316: Initialize two variables in kmp_tasking.
rL263316: Initialize two variables in kmp_tasking.

Summary

Two initialized local variables are causing clang to produce warnings:

./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'num_tasks' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
    default:
    ^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3027:21: note: uninitialized use occurs here
    for( i = 0; i < num_tasks; ++i ) {
                    ^~~~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:28: note: initialize the variable 'num_tasks' to silence this warning
    kmp_uint64 i, num_tasks, extras;
                           ^
                            = 0
./src/projects/openmp/runtime/src/kmp_tasking.c:3019:5: error: variable 'extras' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
    default:
    ^~~~~~~
./src/projects/openmp/runtime/src/kmp_tasking.c:3022:52: note: uninitialized use occurs here
    KMP_DEBUG_ASSERT(tc == num_tasks * grainsize + extras);
                                                   ^~~~~~
./src/projects/openmp/runtime/src/kmp_debug.h:62:60: note: expanded from macro 'KMP_DEBUG_ASSERT'
        #define KMP_DEBUG_ASSERT( cond )       KMP_ASSERT( cond )
                                                           ^
./src/projects/openmp/runtime/src/kmp_debug.h:60:51: note: expanded from macro 'KMP_ASSERT'
        #define KMP_ASSERT( cond )             ( (cond) ? 0 : __kmp_debug_assert( #cond, __FILE__, __LINE__ ) )
                                                  ^
./src/projects/openmp/runtime/src/kmp_tasking.c:2968:36: note: initialize the variable 'extras' to silence this warning
    kmp_uint64 i, num_tasks, extras;
                                   ^
                                    = 0
2 errors generated.

This patch initializes these two variables.

Diff Detail

Event Timeline

sfantao updated this revision to Diff 49881.Mar 5 2016, 11:03 AM

sfantao retitled this revision from to Initialize two variables in kmp_tasking..

sfantao updated this object.

sfantao added a reviewer: jlpeyton.

sfantao added a subscriber: openmp-commits.

Ping!

Looks good to me.

This revision is now accepted and ready to land.Mar 11 2016, 10:25 AM

LGTM as well.

sfantao closed this revision.Mar 11 2016, 5:00 PM

Revision Contents

Path

Size

runtime/

src/

kmp_tasking.c

2 lines

Diff 49881

runtime/src/kmp_tasking.c

	Show First 20 Lines • Show All 2,959 Lines • ▼ Show 20 Lines
	__kmp_taskloop_linear(ident_t loc, int gtid, kmp_task_t task,			__kmp_taskloop_linear(ident_t loc, int gtid, kmp_task_t task,
	kmp_uint64 lb, kmp_uint64 ub, kmp_int64 st,			kmp_uint64 lb, kmp_uint64 ub, kmp_int64 st,
	int sched, kmp_uint64 grainsize, void *task_dup )			int sched, kmp_uint64 grainsize, void *task_dup )
	{			{
	p_task_dup_t ptask_dup = (p_task_dup_t)task_dup;			p_task_dup_t ptask_dup = (p_task_dup_t)task_dup;
	kmp_uint64 tc;			kmp_uint64 tc;
	kmp_uint64 lower = *lb; // compiler provides global bounds here			kmp_uint64 lower = *lb; // compiler provides global bounds here
	kmp_uint64 upper = *ub;			kmp_uint64 upper = *ub;
	kmp_uint64 i, num_tasks, extras;			kmp_uint64 i, num_tasks = 0, extras = 0;
	kmp_info_t *thread = __kmp_threads[gtid];			kmp_info_t *thread = __kmp_threads[gtid];
	kmp_taskdata_t *current_task = thread->th.th_current_task;			kmp_taskdata_t *current_task = thread->th.th_current_task;
	kmp_task_t *next_task;			kmp_task_t *next_task;
	kmp_int32 lastpriv = 0;			kmp_int32 lastpriv = 0;
	size_t lower_offset = (char)lb - (char)task; // remember offset of lb in the task structure			size_t lower_offset = (char)lb - (char)task; // remember offset of lb in the task structure
	size_t upper_offset = (char)ub - (char)task; // remember offset of ub in the task structure			size_t upper_offset = (char)ub - (char)task; // remember offset of ub in the task structure

	// compute trip count			// compute trip count
	▲ Show 20 Lines • Show All 132 Lines • Show Last 20 Lines