This is an archive of the discontinued LLVM Phabricator instance.

[aa-eval] Enhance the comments to better describe the overview of why this pass exists.
ClosedPublic

Authored by chandlerc on Feb 19 2016, 8:15 PM.

Details

Summary

This is based on feedback received when moving this comment from the source
file to a new header file.

Diff Detail

Repository
rL LLVM

Event Timeline

chandlerc updated this revision to Diff 48574.Feb 19 2016, 8:15 PM
chandlerc retitled this revision from to [aa-eval] Enhance the comments to better describe the overview of why this pass exists..
chandlerc updated this object.
chandlerc added a reviewer: reames.
chandlerc added a subscriber: llvm-commits.
reames accepted this revision.Feb 22 2016, 2:29 PM
reames edited edge metadata.

LGTM. IMHO, this didn't really need review.

This revision is now accepted and ready to land.Feb 22 2016, 2:29 PM

LGTM. IMHO, this didn't really need review.

Sure, but mostly wanted to make sure I was at least incorporating the insight you wanted to capture here. I'm not terribly familiar with AA eval in general so, ya know, what do I know. ;]

Also, I'm bad at writing English.

This revision was automatically updated to reflect the committed changes.