This is an archive of the discontinued LLVM Phabricator instance.

Differential D17324

Add a test case in LLVM to ensure covmap section is not created allocatable
ClosedPublic

Authored by davidxl on Feb 16 2016, 7:28 PM.

Details

Reviewers
vsk
Commits
rG23682e9cab92: [PGO] Add test case to ensure covmap section is not allocatable.
rL261959: [PGO] Add test case to ensure covmap section is not allocatable.
Summary

The patch also introduces a X86 subdir which also exists similarly in other instrumentation test suite.

Diff Detail

Event Timeline

davidxl updated this revision to Diff 48145.Feb 16 2016, 7:28 PM
davidxl retitled this revision from to Add a test case in LLVM to ensure covmap section is not created allocatable.
davidxl updated this object.
davidxl added a reviewer: vsk.
davidxl added a subscriber: llvm-commits.
davidxl added a comment.Feb 23 2016, 11:26 AM

ping?

vsk edited edge metadata.Feb 24 2016, 6:18 PM

Sorry for the delay.

In the future, please include pointers to any relevant commits or reviews in your diff description. It would make it easier to understand the situation.

For anyone following along, D16092 made the covmap section non-allocatable for ELF and D16118 added a test to compiler-rt.

test/Instrumentation/InstrProfiling/X86/alloc.ll
4

Is the following a sufficient test?

@a = internal constant i32 0, section "__llvm_covmap"
; CHECK: .section __llvm_covmap,""
4

Instead of adding a new file, would it be possible to check the assembly output of test/profile/Linux/coverage_test.cpp?

davidxl added inline comments.Feb 24 2016, 7:45 PM
test/Instrumentation/InstrProfiling/X86/alloc.ll
4

yes the simplified version would be sufficient -- it is also more preferred than compiler-rt test as you suggested in later comment.

davidxl updated this revision to Diff 49005.Feb 24 2016, 8:04 PM
davidxl edited edge metadata.

Minimize test case according to vsk's feedback.

vsk added a comment.Feb 25 2016, 6:47 PM

Thanks, lgtm with a nit (I think the @__profn_foo can go too).

davidxl added a subscriber: davidxl.Feb 25 2016, 6:51 PM

yes -- editing error :)

Closed by commit rL261959: [PGO] Add test case to ensure covmap section is not allocatable. (authored by davidxl). · Explain WhyFeb 25 2016, 7:09 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
Instrumentation/
InstrProfiling/
X86/
7 lines
3 lines

Diff 49005

test/Instrumentation/InstrProfiling/X86/alloc.ll

;; Ensure that SHF_ALLOC section flag is not set for the __llvm_covmap section on Linux.
; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s
@__profn_foo = private constant [3 x i8] c"foo"
vskUnsubmitted
Not Done
ReplyInline Actions

Is the following a sufficient test?

@a = internal constant i32 0, section "__llvm_covmap"
; CHECK: .section __llvm_covmap,""
vsk: Is the following a sufficient test? ``` @a = internal constant i32 0, section "__llvm_covmap"…
davidxlAuthorUnsubmitted
Not Done
ReplyInline Actions

yes the simplified version would be sufficient -- it is also more preferred than compiler-rt test as you suggested in later comment.

davidxl: yes the simplified version would be sufficient -- it is also more preferred than compiler-rt…
vskUnsubmitted
Not Done
ReplyInline Actions

Instead of adding a new file, would it be possible to check the assembly output of test/profile/Linux/coverage_test.cpp?

vsk: Instead of adding a new file, would it be possible to check the assembly output of…
@__llvm_coverage_mapping = internal constant i32 0, section "__llvm_covmap"
; CHECK-DAG: .section __llvm_covmap,""

test/Instrumentation/InstrProfiling/X86/lit.local.cfg

if not 'X86' in config.root.targets:
config.unsupported = True