This is an archive of the discontinued LLVM Phabricator instance.

Make test/Driver/output-file-cleanup.c hermetic.
ClosedPublic

Authored by jlebar on Feb 12 2016, 2:13 PM.

Download Raw Diff

Details

Reviewers

echristo
• rafael

Commits

rG0e41fa766602: Make test/Driver/output-file-cleanup.c hermetic.
rC261773: Make test/Driver/output-file-cleanup.c hermetic.
rL261773: Make test/Driver/output-file-cleanup.c hermetic.

Summary

It checks that certain files do and exist, so make sure that they don't
exist at the beginning of the test.

This hid a failure in r260448; to see the failure, you had to run the test with
a clean-ish objdir.

Diff Detail

Repository: rL LLVM

Event Timeline

jlebar updated this revision to Diff 47857.Feb 12 2016, 2:13 PM

jlebar retitled this revision from to Make test/Driver/output-file-cleanup.c hermetic..

jlebar updated this object.

jlebar added a reviewer: • rafael.

jlebar added a subscriber: cfe-commits.

jlebar added a reviewer: echristo.Feb 16 2016, 4:44 PM

Upon further consideration, I think I'm going to push this with post-submit review, as we know this test is quite broken, and I think this change is unlikely to make the situation worse.

Closed by commit rL261773: Make test/Driver/output-file-cleanup.c hermetic. (authored by jlebar). · Explain WhyFeb 24 2016, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

cfe/

trunk/

test/

Driver/

output-file-cleanup.c

2 lines

Diff 48975

cfe/trunk/test/Driver/output-file-cleanup.c

				// RUN: rm -f "%t.d" "%t1.s" "%t2.s" "%t3.s" "%t4.s" "%t5.s"
				//
	// RUN: touch %t.s			// RUN: touch %t.s
	// RUN: not %clang -S -DCRASH -o %t.s -MMD -MF %t.d %s			// RUN: not %clang -S -DCRASH -o %t.s -MMD -MF %t.d %s
	// RUN: test ! -f %t.s			// RUN: test ! -f %t.s
	// RUN: test ! -f %t.d			// RUN: test ! -f %t.d

	// RUN: touch %t.s			// RUN: touch %t.s
	// RUN: not %clang -S -DMISSING -o %t.s -MMD -MF %t.d %s			// RUN: not %clang -S -DMISSING -o %t.s -MMD -MF %t.d %s
	// RUN: test ! -f %t.s			// RUN: test ! -f %t.s
	▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines