This is an archive of the discontinued LLVM Phabricator instance.

Differential D17117

[libcxxabi] Fix misleading error message in CMakeLists.txt
ClosedPublic

Authored by Eugene.Zelenko on Feb 10 2016, 5:53 PM.

Details

Reviewers
EricWF
Commits
rG7deb1ac8a1d7: [CMake] Fix misleading error message in CMakeLists.txt.
rCXXA266635: [CMake] Fix misleading error message in CMakeLists.txt.
rL266635: [CMake] Fix misleading error message in CMakeLists.txt.
Summary

This is fix for PR23862.

Diff Detail

Repository
rL LLVM

Event Timeline

Eugene.Zelenko updated this revision to Diff 47570.Feb 10 2016, 5:53 PM
Eugene.Zelenko retitled this revision from to [libcxxabi] Fix misleading error message in CMakeLists.txt.
Eugene.Zelenko updated this object.
Eugene.Zelenko added a reviewer: EricWF.
Eugene.Zelenko set the repository for this revision to rL LLVM.
Eugene.Zelenko added a subscriber: llvm-commits.
EricWF accepted this revision.Apr 15 2016, 9:17 PM
EricWF edited edge metadata.

LGTM thanks.

This revision is now accepted and ready to land.Apr 15 2016, 9:17 PM
Closed by commit rL266635: [CMake] Fix misleading error message in CMakeLists.txt. (authored by eugenezelenko). · Explain WhyApr 18 2016, 10:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
2 lines

Diff 47570

CMakeLists.txt

Context not available.
) )
if (LIBCXXABI_LIBUNWIND_SOURCES STREQUAL "LIBCXXABI_LIBUNWIND_SOURCES-NOTFOUND") if (LIBCXXABI_LIBUNWIND_SOURCES STREQUAL "LIBCXXABI_LIBUNWIND_SOURCES-NOTFOUND")
message(WARNING "LIBCXXABI_LIBCXX_PATH was not specified and couldn't be infered.") message(WARNING "LIBCXXABI_LIBUNWIND_SOURCES was not specified and couldn't be infered.")
set(LIBCXXABI_LIBUNWIND_SOURCES "") set(LIBCXXABI_LIBUNWIND_SOURCES "")
endif() endif()
Context not available.