This is an archive of the discontinued LLVM Phabricator instance.

Fix SocketTest on Windows
ClosedPublic

Authored by zturner on Feb 10 2016, 2:58 PM.

Details

Summary

Hi Vince,

I'm not sure why the #if _WIN32 check is even in there to begin with, but I tested on Windows 7 and Windows 10 and in both cases the output is that of the non _WIN32 path. Were you seeing this other value in practice?

In any case, this patch fixes it for me, so I'm curious to see how this came about.

Diff Detail

Event Timeline

zturner updated this revision to Diff 47537.Feb 10 2016, 2:58 PM
zturner retitled this revision from to Fix SocketTest on Windows.
zturner updated this object.
zturner added a reviewer: vharron.
zturner added a subscriber: lldb-commits.
labath accepted this revision.Feb 12 2016, 5:47 AM
labath added a reviewer: labath.
labath added a subscriber: labath.

We are not running these unittests on windows at the moment. You are the windows maintainer, so if you say this is working for you then remove it. We can always fix things up later...

This revision is now accepted and ready to land.Feb 12 2016, 5:47 AM
This revision was automatically updated to reflect the committed changes.

So I ran the tests on windows (W7 Enterprise) now and I did indeed get the long "0:0:...:1" version here instead of "::1". Maybe we should just accept both versions as correct?

Yea that works