This is an archive of the discontinued LLVM Phabricator instance.

Remove SCEVAAWrapperPass from createLegacyPMAAResults; NFC
ClosedPublic

Authored by sanjoy on Feb 8 2016, 4:39 PM.

Download Raw Diff

Details

Reviewers

Commits

rG55394d929c6a: Remove SCEVAAWrapperPass from createLegacyPMAAResults; NFC
rL260182: Remove SCEVAAWrapperPass from createLegacyPMAAResults; NFC

Summary

createLegacyPMAAResults is only called by CGSCC and Module passes, so
the call to getAnalysisIfAvailable<SCEVAAWrapperPass>() never
succeeds (SCEVAAWrapperPass is a function pass).

Diff Detail

Event Timeline

sanjoy updated this revision to Diff 47272.Feb 8 2016, 4:39 PM

sanjoy retitled this revision from to Remove SCEVAAWrapperPass from createLegacyPMAAResults; NFC.

sanjoy updated this object.

sanjoy added a reviewer: chandlerc.

sanjoy added a subscriber: llvm-commits.

Herald added a subscriber: mcrosier. · View Herald TranscriptFeb 8 2016, 4:39 PM

LGTM, thanks for fixing my goof. =D

This revision is now accepted and ready to land.Feb 8 2016, 4:47 PM

Closed by commit rL260182: Remove SCEVAAWrapperPass from createLegacyPMAAResults; NFC (authored by sanjoy). · Explain WhyFeb 8 2016, 5:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Analysis/

AliasAnalysis.cpp

2 lines

Diff 47272

lib/Analysis/AliasAnalysis.cpp

Show First 20 Lines • Show All 524 Lines • ▼ Show 20 Lines	if (auto *WrapperPass =
AAR.addAAResult(WrapperPass->getResult());		AAR.addAAResult(WrapperPass->getResult());
if (auto *WrapperPass = P.getAnalysisIfAvailable<TypeBasedAAWrapperPass>())		if (auto *WrapperPass = P.getAnalysisIfAvailable<TypeBasedAAWrapperPass>())
AAR.addAAResult(WrapperPass->getResult());		AAR.addAAResult(WrapperPass->getResult());
if (auto *WrapperPass =		if (auto *WrapperPass =
P.getAnalysisIfAvailable<objcarc::ObjCARCAAWrapperPass>())		P.getAnalysisIfAvailable<objcarc::ObjCARCAAWrapperPass>())
AAR.addAAResult(WrapperPass->getResult());		AAR.addAAResult(WrapperPass->getResult());
if (auto *WrapperPass = P.getAnalysisIfAvailable<GlobalsAAWrapperPass>())		if (auto *WrapperPass = P.getAnalysisIfAvailable<GlobalsAAWrapperPass>())
AAR.addAAResult(WrapperPass->getResult());		AAR.addAAResult(WrapperPass->getResult());
if (auto *WrapperPass = P.getAnalysisIfAvailable<SCEVAAWrapperPass>())
AAR.addAAResult(WrapperPass->getResult());
if (auto *WrapperPass = P.getAnalysisIfAvailable<CFLAAWrapperPass>())		if (auto *WrapperPass = P.getAnalysisIfAvailable<CFLAAWrapperPass>())
AAR.addAAResult(WrapperPass->getResult());		AAR.addAAResult(WrapperPass->getResult());

return AAR;		return AAR;
}		}

bool llvm::isNoAliasCall(const Value *V) {		bool llvm::isNoAliasCall(const Value *V) {
if (auto CS = ImmutableCallSite(V))		if (auto CS = ImmutableCallSite(V))
Show All 25 Lines