This is an archive of the discontinued LLVM Phabricator instance.

Differential D16883

Fix build LLVM with -D LLVM_USE_INTEL_JITEVENTS:BOOL=ON
ClosedPublic

Authored by etyurin on Feb 4 2016, 5:36 AM.

Details

Reviewers
andrew.w.kaylor
chandlerc
eliben
Summary

The problem is a missing dependency on llvm/IR/Attributes.inc generating target in LLVMIntelJITEvents CMakeLists.txt.

A patch by Tyurin, Evgeniy.

Diff Detail

Event Timeline

etyurin updated this revision to Diff 46901.Feb 4 2016, 5:36 AM
etyurin retitled this revision from to Fix build LLVM with -D LLVM_USE_INTEL_JITEVENTS:BOOL=ON.
etyurin updated this object.
etyurin added reviewers: andrew.w.kaylor, eliben, chandlerc.
etyurin added a subscriber: llvm-commits.
andrew.w.kaylor accepted this revision.Feb 4 2016, 10:45 AM
andrew.w.kaylor edited edge metadata.

LGTM

This revision is now accepted and ready to land.Feb 4 2016, 10:45 AM
andrew.w.kaylor mentioned this in D16940: Fix build LLVM with -D LLVM_USE_INTEL_JITEVENTS:BOOL=ON on Windows.Feb 5 2016, 5:04 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.Sep 26 2016, 2:12 PM

Looks like patch was not committed.

etyurin added a comment.Sep 26 2016, 11:22 PM
In D16883#553021, @Eugene.Zelenko wrote:

Looks like patch was not committed.

Another version was committed.
https://reviews.llvm.org/D16940

andrew.w.kaylor closed this revision.Sep 27 2016, 6:56 AM

Revision Contents

PathSize
lib/
ExecutionEngine/
IntelJITEvents/
3 lines

Diff 46901

lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt

include_directories( ${CMAKE_CURRENT_SOURCE_DIR}/.. ) include_directories( ${CMAKE_CURRENT_SOURCE_DIR}/.. )
add_llvm_library(LLVMIntelJITEvents add_llvm_library(LLVMIntelJITEvents
IntelJITEventListener.cpp IntelJITEventListener.cpp
jitprofiling.c jitprofiling.c
LINK_LIBS pthread ${CMAKE_DL_LIBS}
)
LINK_LIBS pthread ${CMAKE_DL_LIBS} add_dependencies(LLVMIntelJITEvents intrinsics_gen)
)