Page MenuHomePhabricator

AMDGPU: Preserve alignments on new created globals
ClosedPublic

Authored by arsenm on Feb 3 2016, 10:10 AM.

Details

Reviewers
tstellarAMD
Summary

Also switch to internal linkage, and include the name of the function in the name.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 46804.Feb 3 2016, 10:10 AM
arsenm retitled this revision from to AMDGPU: Preserve alignments on new created globals.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Feb 3 2016, 8:43 PM
tstellarAMD edited edge metadata.

LGTM. Is the alignment on global variables actually used for things? I thought it was the alignment on loads/stores that mattered.

This revision is now accepted and ready to land.Feb 3 2016, 8:43 PM
arsenm added a comment.Feb 3 2016, 9:19 PM

LGTM. Is the alignment on global variables actually used for things? I thought it was the alignment on loads/stores that mattered.

The alignment of the load/store must be >= the alignment of the actual address of the indexed value

arsenm closed this revision.Feb 5 2016, 11:51 AM

r259911