[OpenCL] Stop treating OpenCL builtin functions as standard C library functions

[yaxunl]

Summary

OpenCL v1.2 s6.9.f: The library functions defined in the C99 standard headers are not available.

This change stops treating OpenCL builtin functions as standard C library functions to eliminate warning messages about printf format string.

Differential Revision: http://reviews.llvm.org/D16812

[Anastasia]

test/SemaOpenCL/printf.cl

9 ↗

(On Diff #46670)

I think it's more common to put "// expected-no-diagnostics" just after the RUN line.

[yaxunl]

Revised as Anastasia suggested.

[pxli168]

lib/AST/Decl.cpp

2735 ↗

(On Diff #46830)

Keep the style to others comment and you can write like:
OpenCL v1.2 s6.9.f - the library functions....

You do not need to write about how or where you get this require, you just need to give the reference.

[Anastasia]

LGTM! Please change the comment as suggested.

lib/AST/Decl.cpp

2735 ↗

(On Diff #46830)

Upper case after "-" please :)

OpenCL v1.2 s6.9.f - The library functions....

[yaxunl]

Revised as Xiuli suggested.

[pxli168]

LGTM, thanks！

[yaxunl]

ping

[Anastasia]

@pekka, if you don't have any additional comments here we will proceed committing it.

Thanks!

[pekka.jaaskelainen]

LGTM

[Anastasia]

Thanks! Committed with a slight change of putting the test into test/SemaOpenCL/builtin.cl. I think it belongs to the same category and I find it better to group related things. I hope you are fine with this.

[yaxunl]

I am OK with that. Thanks!

cfe/trunk/lib/AST/Decl.cpp

unsigned FunctionDecl::getBuiltinID() const {
   // This function has the name of a known C library
   // function. Determine whether it actually refers to the C library
   // function or whether it just has the same name.
 
   // If this is a static function, it's not a builtin.
   if (getStorageClass() == SC_Static)
     return 0;
 
+  // OpenCL v1.2 s6.9.f - The library functions defined in
+  // the C99 standard headers are not available.
+  if (Context.getLangOpts().OpenCL &&
+      Context.BuiltinInfo.isPredefinedLibFunction(BuiltinID))
+    return 0;
+
   return BuiltinID;
 }
 
 
 /// getNumParams - Return the number of parameters this function must have
 /// based on its FunctionType.  This is the length of the ParamInfo array
 /// after it has been created.
 unsigned FunctionDecl::getNumParams() const {

cfe/trunk/test/SemaOpenCL/builtin.cl

 // RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only
 
-float __attribute__((overloadable)) acos(float); // expected-no-diagnostics
+// expected-no-diagnostics
+
+float __attribute__((overloadable)) acos(float);
+
+typedef float float4 __attribute__((ext_vector_type(4)));
+int printf(__constant const char* st, ...);
+
+void test(void)
+{
+  float4 a;
+  printf("%8.4v4hlf\n", a);
+}