Page MenuHomePhabricator
Differential D16811

[mips] Range check simm4.
ClosedPublic
Actions

Authored by dsanders on Feb 2 2016, 9:33 AM.

Details

Reviewers
vkalintiris
Commits
rG78e890209791: [mips] Range check simm4.
rL263220: [mips] Range check simm4.
Summary

Depends on D15521

Diff Detail

Event Timeline

dsanders updated this revision to Diff 46668.Feb 2 2016, 9:33 AM
dsanders retitled this revision from to [mips] Range check simm4..
dsanders updated this object.
dsanders added a reviewer: vkalintiris.
dsanders added a parent revision: D15521: [mips] Range check uimm20 and fixed a bug this revealed..
dsanders added a subscriber: llvm-commits.
Herald added a subscriber: dsanders. · View Herald TranscriptFeb 2 2016, 9:33 AM
dsanders updated this revision to Diff 46760.Feb 3 2016, 3:39 AM

Fix operand ordering to avoid tablegen assertion.

dsanders added a comment.Feb 16 2016, 6:19 AM

ping

dsanders added a child revision: D17291: [mips] Range check uimm6_lsl2..Feb 16 2016, 7:25 AM
vkalintiris accepted this revision.Feb 29 2016, 3:48 AM
vkalintiris edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Feb 29 2016, 3:48 AM
dsanders updated this revision to Diff 49383.Feb 29 2016, 8:58 AM
dsanders edited edge metadata.

Rebase before commit

dsanders closed this revision.Mar 11 2016, 3:42 AM

Revision Contents
Changeset List

PathSize
lib/
Target/
Mips/
AsmParser/
27 lines
Disassembler/
26 lines
3 lines
28 lines
test/
MC/
Mips/
1 line
micromips/
2 lines
micromips32r6/
3 lines
micromips64r6/
3 lines

Diff 46760

View Options

lib/Target/Mips/AsmParser/MipsAsmParser.cpp

Loading...
View Options

lib/Target/Mips/Disassembler/MipsDisassembler.cpp

Loading...
View Options

lib/Target/Mips/MicroMipsInstrInfo.td

Loading...
View Options

lib/Target/Mips/MipsInstrInfo.td

Loading...
View Options

test/MC/Mips/micromips-invalid.s

Loading...
View Options

test/MC/Mips/micromips/invalid.s

Loading...
View Options

test/MC/Mips/micromips32r6/invalid.s

Loading...
View Options

test/MC/Mips/micromips64r6/invalid.s

Loading...