Page MenuHomePhabricator

AMDGPU: Whitelist handled intrinsics
ClosedPublic

Authored by arsenm on Feb 1 2016, 9:51 AM.

Details

Reviewers
tstellarAMD
Summary

We shouldn't crash on unhandled intrinsics. Also simplify failure handling in loop.

Diff Detail

Event Timeline

arsenm updated this revision to Diff 46550.Feb 1 2016, 9:51 AM
arsenm retitled this revision from to AMDGPU: Stop pointlessly looking at users after a bad one is found.
arsenm updated this object.
arsenm added a reviewer: tstellarAMD.
arsenm added a subscriber: llvm-commits.
arsenm updated this revision to Diff 46587.Feb 1 2016, 4:11 PM
arsenm retitled this revision from AMDGPU: Stop pointlessly looking at users after a bad one is found to AMDGPU: Whitelist handled intrinsics.
arsenm updated this object.
tstellarAMD accepted this revision.Feb 2 2016, 8:39 AM
tstellarAMD edited edge metadata.

LGTM.

lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
526–527

I'm not sure why this is here. If it doesn't make sense, feel free to remove it.

This revision is now accepted and ready to land.Feb 2 2016, 8:39 AM
arsenm closed this revision.Feb 2 2016, 11:24 AM

r259546

lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp
526–527

I think we should replace it with a return false and an assert so it comes up again when calls are supported