Page MenuHomePhabricator

Lower inlining threshold when the caller has minsize attribute
ClosedPublic

Authored by eraman on Jan 22 2016, 4:56 PM.

Details

Summary

When the caller has optsize attribute, we reduce the inlinining threshold to OptSizeThreshold (=75) if it is not already lower than that. We don't do the same for minsize and I suspect it was not intentional. This also addresses a FIXME regarding checking optsize attribute explicitly instead of using the right wrapper.

Diff Detail

Repository
rL LLVM

Event Timeline

eraman updated this revision to Diff 45771.Jan 22 2016, 4:56 PM
eraman retitled this revision from to Lower inlining threshold when the caller has minsize attribute.
eraman updated this object.
eraman added a reviewer: hfinkel.
eraman added a subscriber: llvm-commits.

Hal, do you have any comments?

hfinkel accepted this revision.Jan 28 2016, 3:44 PM
hfinkel edited edge metadata.

Hal, do you have any comments?

LGTM too.

This revision is now accepted and ready to land.Jan 28 2016, 3:44 PM
This revision was automatically updated to reflect the committed changes.