Fix printing of types in initializers with suppressed tags.

[nick.sumner]

Summary

Tag and specifier printing can be suppressed in Decl::printGroup, but these suppressions leak into the initializers. Thus

int *x = ((void *)0), *y = ((void *)0);

gets printed as

int *x = ((void *)0), *y = ((*)0);

And

struct { struct Z z; } z = {(struct Z){}};

gets printed as

struct { struct Z z; } z = {(){}};

The stops the suppressions from leaking into the initializers.

[rsmith]

lib/AST/StmtPrinter.cpp

132 ↗

(On Diff #45634)

Maybe we should instead do this whenever we start printing a variable's initializer? I don't think your patch will fix the same bug in this case:

struct X {};
struct { int n; } x = { [](struct X *x) { return 0; }(0) };

[nick.sumner]

Updated to reset tag and specifier suppression precisely when printing initializers.

[rsmith]

LGTM, thanks! Do you have SVN commit access?

[nick.sumner]

Thanks for your help!

I don't have SVN commit access.

lib/AST/DeclPrinter.cpp

if (CXXConstructExpr *Construct =
       }
     }
     if (!ImplicitInit) {
       if ((D->getInitStyle() == VarDecl::CallInit) && !isa<ParenListExpr>(Init))
         Out << "(";
       else if (D->getInitStyle() == VarDecl::CInit) {
         Out << " = ";
       }
-      Init->printPretty(Out, nullptr, Policy, Indentation);
+      PrintingPolicy SubPolicy(Policy);
+      SubPolicy.SuppressSpecifiers = false;
+      SubPolicy.SuppressTag = false;
+      Init->printPretty(Out, nullptr, SubPolicy, Indentation);
       if ((D->getInitStyle() == VarDecl::CallInit) && !isa<ParenListExpr>(Init))
         Out << ")";
     }
   }
   prettyPrintAttributes(D);
 }
 
 void DeclPrinter::VisitParmVarDecl(ParmVarDecl *D) {

test/Sema/ast-print.c

 
 struct pair_t {
   int a;
   int b;
 };
 
 // CHECK: struct pair_t p = {a: 3, .b = 4};
 struct pair_t p = {a: 3, .b = 4};
+
+void initializers() {
+  // CHECK: int *x = ((void *)0), *y = ((void *)0);
+  int *x = ((void *)0), *y = ((void *)0);
+  struct Z{};
+  struct {
+    struct Z z;
+  // CHECK: } z = {(struct Z){}};
+  } z = {(struct Z){}};
+}