This fixes the nine tests that regressed on Windows after http://reviews.llvm.org/D16186
Details
Details
- Reviewers
zturner clayborg tberghammer - Commits
- rG225d3ea34010: Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly)…
rLLDB258429: Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that (nearly)…
rL258429: Add CalculateSymbolSizes in ObjectFilePECOFF::GetSymtab to ensure that…
Diff Detail
Diff Detail
Event Timeline
Comment Actions
looks fine to me, but some Apple targets use PE, so +greg in case he can think of a reason why this will mess up something on the Apple side.
Comment Actions
Looks good to me and if Apple using this code then I am pretty sure my CL break them as well. Having 0 size symbols around will cause a lot of issue around LLDB.
Comment Actions
I just added PECOFF so I could make sure I had 3 clients for the ObjectFile class when I was developing it and I already have the PECOFF support in the previous tool I had written, so this is quite fine to do. I could even fine a PECOFF file that had a symbol table when I made ObjectFilePECOFF so I wasn't able to actually use any of the symbols. We don't use PECOFF at Apple, so this looks good.