Page MenuHomePhabricator

Do not define GXX_RTTI macro for C
ClosedPublic

Authored by ygao on Jan 20 2016, 11:15 AM.

Details

Summary

Hi,
I was looking at the list of pre-defined macros by the new LLVM release and noticed that the __GXX_RTTI macro is being defined for both C and C++, and I wonder maybe it makes sense to only enable RTTI for C++. What do you think?
Thanks in advance,

  • Gao

Diff Detail

Repository
rL LLVM

Event Timeline

ygao updated this revision to Diff 45416.Jan 20 2016, 11:15 AM
ygao retitled this revision from to Do not define GXX_RTTI macro for C.
ygao updated this object.
ygao added a reviewer: rsmith.
ygao added a subscriber: cfe-commits.
ygao added a comment.Jan 25 2016, 4:59 PM

A gentle ping.

rsmith edited edge metadata.Jan 26 2016, 6:16 AM
rsmith added a subscriber: rsmith.

LGTM, assuming this is the same behaviour as GCC.

This revision was automatically updated to reflect the committed changes.