This is an archive of the discontinued LLVM Phabricator instance.

Remove one dead PointerType::getElementType() call.
ClosedPublic

Authored by eddyb on Jan 17 2016, 11:29 AM.

Download Raw Diff

Details

Reviewers

dblaikie
mjacob

Commits

rGda2c9baa0735: [NFC] Remove one dead PointerType::getElementType() call.
rL258022: [NFC] Remove one dead PointerType::getElementType() call.

Diff Detail

Event Timeline

eddyb updated this revision to Diff 45113.Jan 17 2016, 11:29 AM

eddyb retitled this revision from to Remove one dead getPointerElementType() call..

eddyb updated this object.

eddyb added a reviewer: mjacob.

eddyb added subscribers: dblaikie, llvm-commits.

eddyb retitled this revision from Remove one dead getPointerElementType() call. to Remove one dead PointerType::getElementType() call..Jan 17 2016, 12:35 PM

thanks - please commit!

This revision is now accepted and ready to land.Jan 17 2016, 1:47 PM

LGTM too. I'll commit it for you.

Closed by commit rL258022: [NFC] Remove one dead PointerType::getElementType() call. (authored by mjacob). · Explain WhyJan 17 2016, 2:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lib/

Analysis/

VectorUtils.cpp

2 lines

Diff 45113

lib/Analysis/VectorUtils.cpp

Show First 20 Lines • Show All 312 Lines • ▼ Show 20 Lines	Value llvm::getStrideFromPointer(Value Ptr, ScalarEvolution SE, Loop Lp) {

V = S->getStepRecurrence(*SE);		V = S->getStepRecurrence(*SE);
if (!V)		if (!V)
return nullptr;		return nullptr;

// Strip off the size of access multiplication if we are still analyzing the		// Strip off the size of access multiplication if we are still analyzing the
// pointer.		// pointer.
if (OrigPtr == Ptr) {		if (OrigPtr == Ptr) {
const DataLayout &DL = Lp->getHeader()->getModule()->getDataLayout();
DL.getTypeAllocSize(PtrTy->getElementType());
if (const SCEVMulExpr *M = dyn_cast<SCEVMulExpr>(V)) {		if (const SCEVMulExpr *M = dyn_cast<SCEVMulExpr>(V)) {
if (M->getOperand(0)->getSCEVType() != scConstant)		if (M->getOperand(0)->getSCEVType() != scConstant)
return nullptr;		return nullptr;

const APInt &APStepVal = cast<SCEVConstant>(M->getOperand(0))->getAPInt();		const APInt &APStepVal = cast<SCEVConstant>(M->getOperand(0))->getAPInt();

// Huge step value - give up.		// Huge step value - give up.
if (APStepVal.getBitWidth() > 64)		if (APStepVal.getBitWidth() > 64)
▲ Show 20 Lines • Show All 237 Lines • Show Last 20 Lines