This is an archive of the discontinued LLVM Phabricator instance.

[DwarfDebug] Don't merge DebugLocEntries if their pieces overlap
ClosedPublic

Authored by loladiro on Jan 15 2016, 4:38 PM.

Details

Summary

Later in DWARF emission we check that DebugLocEntries have
non-overlapping pieces, so we should create any such entries
by merging here.

Fixes PR26163.

Diff Detail

Event Timeline

loladiro updated this revision to Diff 45057.Jan 15 2016, 4:38 PM
loladiro retitled this revision from to [DwarfDebug] Don't merge DebugLocEntries if their pieces overlap.
loladiro updated this object.
loladiro added a reviewer: aprantl.
loladiro added a subscriber: llvm-commits.
loladiro updated this revision to Diff 45058.Jan 15 2016, 4:40 PM

clang-format (sorry forgot)

aprantl accepted this revision.Jan 15 2016, 4:52 PM
aprantl edited edge metadata.

Thanks!

lib/CodeGen/AsmPrinter/DwarfDebug.cpp
808

Please move the function to the cpp in a separate NFC commit. It helps with bisection and git blame.

817

This appears to be reasonable to me.

test/DebugInfo/ARM/PR26163.ll
8

Sad but true.

This revision is now accepted and ready to land.Jan 15 2016, 4:52 PM
aprantl added inline comments.Jan 15 2016, 4:53 PM
test/DebugInfo/ARM/PR26163.ll
74

Can you remove all the unnecessary attributes? Usually that's all of them.

dim added a subscriber: dim.Jan 15 2016, 5:17 PM

Note: please consider that this should be merged to the 3.8 branch (with rL257977 probably).

This revision was automatically updated to reflect the committed changes.
In D16249#328466, @dim wrote:

Note: please consider that this should be merged to the 3.8 branch (with rL257977 probably).

Yep, I requested as much from the release owner.