Page MenuHomePhabricator

Fix the cross compilation of unit tests. NFC (second attempt)
ClosedPublic

Authored by sgundapa on Jan 13 2016, 4:52 PM.

Details

Summary

With COMPILER_RT_INCLUDE_TESTS turned ON and in a cross compiling
environment, the unit tests fail to link. This patch does the following changes

Rename COMPILER_RT_TEST_CFLAGS to COMPILER_RT_UNITTEST_CFLAGS to reflect the way it's used.
Add COMPILER_RT_TEST_COMPILER_CFLAGS to COMPILER_RT_UNITTEST_CFLAGS so that cross-compiler would be able to build/compile the unit tests
Add COMPILER_RT_UNITTEST_LINKFLAGS to COMPILER_RT_UNITTEST_CFLAGS so that cross-compiler would be able to link the unit tests (if needed)

Diff Detail

Repository
rL LLVM

Event Timeline

sgundapa updated this revision to Diff 44816.Jan 13 2016, 4:52 PM
sgundapa retitled this revision from to Fix the cross compilation of unit tests. NFC (second attempt).
sgundapa updated this object.
sgundapa added reviewers: samsonov, rengolin.
sgundapa added a subscriber: llvm-commits.
samsonov accepted this revision.Jan 13 2016, 4:53 PM
samsonov edited edge metadata.

LGTM

This revision is now accepted and ready to land.Jan 13 2016, 4:53 PM
This revision was automatically updated to reflect the committed changes.