This is an archive of the discontinued LLVM Phabricator instance.

[CUDA] Add tests for compiling CUDA files with -E.
ClosedPublic

Authored by jlebar on Jan 11 2016, 1:19 PM.

Download Raw Diff

Details

Reviewers

Commits

rG2b187c3977fd: [CUDA] Add tests for compiling CUDA files with -E.
rC257807: [CUDA] Add tests for compiling CUDA files with -E.
rL257807: [CUDA] Add tests for compiling CUDA files with -E.

Diff Detail

Event Timeline

jlebar updated this revision to Diff 44541.Jan 11 2016, 1:19 PM

jlebar retitled this revision from to [CUDA] Add tests for compiling CUDA files with -E..

jlebar updated this object.

jlebar added a reviewer: tra.

jlebar added subscribers: jhen, cfe-commits.

tra added inline comments.Jan 13 2016, 10:15 AM

test/Driver/cuda-preprocess.cu
13–16	Given it's a driver test you probably just want to check the list of commands generated by driver (-###) Checking preprocessing results would probably belong to test/Preprocessor.
17	This would succeed if we fail to preprocess as it would catch 'clang_unittest_no_arch' in the #ifndef above. I'd add some macro which will get preprocessed away: #ifndef __CUDA_ARCH__ #define PREPROCESSED_AWAY clang_unittest_no_arch __ PREPROCESSED_AWAY ... It may be an overkill, though. Up to you.

Address tra's review comments.

jlebar marked 2 inline comments as done.Jan 13 2016, 6:10 PM

jlebar added inline comments.

test/Driver/cuda-preprocess.cu
13–16	Cool, moved to Preprocessor/.
17	sgtm, done.

Thank you for the review, Artem.

tra accepted this revision.Jan 14 2016, 11:29 AM

tra edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2016, 11:29 AM

Closed by commit rL257807: [CUDA] Add tests for compiling CUDA files with -E. (authored by jlebar). · Explain WhyJan 14 2016, 1:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

Driver/

cuda-preprocess.cu

29 lines

Diff 44541

test/Driver/cuda-preprocess.cu

This file was added.

				// Tests CUDA compilation with -E.

				// REQUIRES: clang-driver
				// REQUIRES: x86-registered-target
				// REQUIRES: nvptx-registered-target

				#ifndef __CUDA_ARCH__
				clang_unittest_no_arch
				#else
				clang_unittest_cuda_arch __CUDA_ARCH__
				#endif

				// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \
				// RUN: \| FileCheck -check-prefix NOARCH %s
				// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 --cuda-host-only %s 2>&1 \
				// RUN: \| FileCheck -check-prefix NOARCH %s
				traUnsubmitted Done Reply Inline Actions Given it's a driver test you probably just want to check the list of commands generated by driver (-###) Checking preprocessing results would probably belong to test/Preprocessor. tra: Given it's a driver test you probably just want to check the list of commands generated by…
				jlebarAuthorUnsubmitted Not Done Reply Inline Actions Cool, moved to Preprocessor/. jlebar: Cool, moved to Preprocessor/.
				// NOARCH: clang_unittest_no_arch
				traUnsubmitted Done Reply Inline Actions This would succeed if we fail to preprocess as it would catch 'clang_unittest_no_arch' in the #ifndef above. I'd add some macro which will get preprocessed away: #ifndef __CUDA_ARCH__ #define PREPROCESSED_AWAY clang_unittest_no_arch __ PREPROCESSED_AWAY ... It may be an overkill, though. Up to you. tra: This would succeed if we fail to preprocess as it would catch 'clang_unittest_no_arch' in the…
				jlebarAuthorUnsubmitted Not Done Reply Inline Actions sgtm, done. jlebar: sgtm, done.

				// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 --cuda-device-only %s 2>&1 \
				// RUN: \| FileCheck -check-prefix SM20 %s
				// SM20: clang_unittest_cuda_arch 200

				// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_30 --cuda-device-only %s 2>&1 \
				// RUN: \| FileCheck -check-prefix SM30 %s
				// SM30: clang_unittest_cuda_arch 300

				// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 --cuda-gpu-arch=sm_30 \
				// RUN: --cuda-device-only %s 2>&1 \
				// RUN: \| FileCheck -check-prefix SM20 -check-prefix SM30 %s