Page MenuHomePhabricator

[mips] Never select JAL for calls to an absolute immediate address.
ClosedPublic

Authored by dsanders on Jan 11 2016, 2:48 AM.

Details

Summary

It actually takes an offset into the current PC-region.

This is expected to fix the 'expr' command in lldb.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 44455.Jan 11 2016, 2:48 AM
dsanders retitled this revision from to [mips] Never select JAL for calls to an absolute immediate address..
dsanders updated this object.
dsanders added reviewers: vkalintiris, jaydeep, bhushan.
dsanders added a subscriber: llvm-commits.
vkalintiris accepted this revision.Jan 11 2016, 4:03 AM
vkalintiris edited edge metadata.

The changes LGTM. @jaydeep, @bhushan: Does this fix the expr command in LLDB?

This revision is now accepted and ready to land.Jan 11 2016, 4:03 AM
jaydeep accepted this revision.Jan 11 2016, 4:46 AM
jaydeep edited edge metadata.

This fixes the expr issue in LLDB

bhushan accepted this revision.Jan 11 2016, 4:52 AM
bhushan edited edge metadata.

Yes, it does fix the issue.

dsanders closed this revision.Jan 11 2016, 8:01 AM