This is an archive of the discontinued LLVM Phabricator instance.

Differential D159463

[include-cleaner] Map the 4-argument move overload to the algorithm header.
ClosedPublic

Authored by VitaNuo on Sep 6 2023, 4:27 AM.

Details

Reviewers
kadircet
Commits
rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header.

Diff Detail

Event Timeline

VitaNuo created this revision.Sep 6 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2023, 4:27 AM
Herald added a subscriber: kadircet. · View Herald Transcript
VitaNuo requested review of this revision.Sep 6 2023, 4:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 6 2023, 4:27 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
VitaNuo added a reviewer: kadircet.Sep 6 2023, 4:27 AM
kadircet accepted this revision.Sep 6 2023, 4:37 AM
This revision is now accepted and ready to land.Sep 6 2023, 4:37 AM
This revision was landed with ongoing or failed builds.Sep 6 2023, 4:39 AM
Closed by commit rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header. (authored by VitaNuo). · Explain Why
This revision was automatically updated to reflect the committed changes.
VitaNuo added a commit: rGd71adebb9fb8: [include-cleaner] Map the 4-argument move overload to the algorithm header..
Harbormaster completed remote builds in B256694: Diff 556003.Sep 6 2023, 4:47 AM

Revision Contents

PathSize
clang-tools-extra/
include-cleaner/
lib/
4 lines
unittests/
10 lines

Diff 556005

clang-tools-extra/include-cleaner/lib/FindHeaders.cpp

Show First 20 Lines • Show All 119 Lines • ▼ Show 20 LinesheaderForAmbiguousStdSymbol(const NamedDecl *ND) {
const auto *FD = ND->getAsFunction(); const auto *FD = ND->getAsFunction();
if (!FD) if (!FD)
return std::nullopt; return std::nullopt;
llvm::StringRef FName = symbolName(*ND); llvm::StringRef FName = symbolName(*ND);
if (FName == "move") { if (FName == "move") {
if (FD->getNumParams() == 1) if (FD->getNumParams() == 1)
// move(T&& t) // move(T&& t)
return tooling::stdlib::Header::named("<utility>"); return tooling::stdlib::Header::named("<utility>");
if (FD->getNumParams() == 3) if (FD->getNumParams() == 3 || FD->getNumParams() == 4)
// move(InputIt first, InputIt last, OutputIt dest); // move(InputIt first, InputIt last, OutputIt dest);
// move(ExecutionPolicy&& policy, ForwardIt1 first,
// ForwardIt1 last, ForwardIt2 d_first);
return tooling::stdlib::Header::named("<algorithm>"); return tooling::stdlib::Header::named("<algorithm>");
} else if (FName == "remove") { } else if (FName == "remove") {
if (FD->getNumParams() == 1) if (FD->getNumParams() == 1)
// remove(const char*); // remove(const char*);
return tooling::stdlib::Header::named("<cstdio>"); return tooling::stdlib::Header::named("<cstdio>");
if (FD->getNumParams() == 3) if (FD->getNumParams() == 3)
// remove(ForwardIt first, ForwardIt last, const T& value); // remove(ForwardIt first, ForwardIt last, const T& value);
return tooling::stdlib::Header::named("<algorithm>"); return tooling::stdlib::Header::named("<algorithm>");
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines

clang-tools-extra/include-cleaner/unittests/FindHeadersTest.cpp

Show First 20 Lines • Show All 543 Lines • ▼ Show 20 Lines llvm::StringRef ExpectedHeader;
constexpr OutputIt move(InputIt first, InputIt last, OutputIt dest); constexpr OutputIt move(InputIt first, InputIt last, OutputIt dest);
})cpp", })cpp",
"move", "move",
"<algorithm>", "<algorithm>",
}, },
{ {
R"cpp( R"cpp(
namespace std { namespace std {
template<class ExecutionPolicy, class ForwardIt1, class ForwardIt2>
ForwardIt2 move(ExecutionPolicy&& policy,
ForwardIt1 first, ForwardIt1 last, ForwardIt2 d_first);
})cpp",
"move",
"<algorithm>",
},
{
R"cpp(
namespace std {
template<typename T> constexpr T move(T&& t) noexcept; template<typename T> constexpr T move(T&& t) noexcept;
})cpp", })cpp",
"move", "move",
"<utility>", "<utility>",
}, },
{ {
R"cpp( R"cpp(
namespace std { namespace std {
Show All 34 Lines