Page MenuHomePhabricator

Revert "GlobalsAA: Take advantage of ArgMemOnly, InaccessibleMemOnly and InaccessibleMemOrArgMemOnly attributes"
ClosedPublic

Authored by deadalnix on Jan 6 2016, 1:45 AM.

Details

Summary

This reverts commit 5a9e526f29cf8510ab5c3d566fbdcf47ac24e1e9.

As per discussion in D15665

This also add a test case so that regression introduced by that diff are not reintroduced.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix updated this revision to Diff 44101.Jan 6 2016, 1:45 AM
deadalnix retitled this revision from to Revert "GlobalsAA: Take advantage of ArgMemOnly, InaccessibleMemOnly and InaccessibleMemOrArgMemOnly attributes".
deadalnix updated this object.
deadalnix added a subscriber: llvm-commits.
vaivaswatha edited edge metadata.Jan 6 2016, 4:10 AM

Thanks for doing this.

lib/Analysis/GlobalsModRef.cpp
388 ↗(On Diff #44101)

In my opinion, this part can actually stay. I'll let the others decide though.

deadalnix added inline comments.Jan 6 2016, 5:14 AM
lib/Analysis/GlobalsModRef.cpp
388 ↗(On Diff #44101)

Even if we want to go that road, I think it makes sense to do a clean revert and then reintroduce the changes that makes sense in their own diifs, with their own tests.

jmolloy accepted this revision.Jan 6 2016, 5:20 AM
jmolloy edited edge metadata.
jmolloy added inline comments.
lib/Analysis/GlobalsModRef.cpp
388 ↗(On Diff #44101)

Agreed. Let's just do the revert and then reapply any applicable hunks with tests.

This revision is now accepted and ready to land.Jan 6 2016, 5:20 AM
This revision was automatically updated to reflect the committed changes.