This is an archive of the discontinued LLVM Phabricator instance.

[IR] Make detailed structural hash test look at diffs
ClosedPublic

Authored by aidengrossman on Aug 29 2023, 7:33 PM.

Details

Summary

This patch makes structural-hash-detailed.ll look at diffs rather than
specific values to make the test more robust against the underlying
hashing implementation while still testing that the hash value is
deterministic across multiple runs.

Diff Detail

Event Timeline

aidengrossman created this revision.Aug 29 2023, 7:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 7:33 PM
aidengrossman requested review of this revision.Aug 29 2023, 7:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 7:33 PM
aidengrossman retitled this revision from [IR] Make detailed structural hash test llok at diffs to [IR] Make detailed structural hash test look at diffs.Aug 30 2023, 12:32 AM
aeubanks accepted this revision.Aug 30 2023, 9:29 AM
aeubanks added inline comments.
llvm/test/Analysis/StructuralHash/structural-hash-detailed.ll
5–11

can FileCheck --input-file=%t.1 %s below to run opt one less time

This revision is now accepted and ready to land.Aug 30 2023, 9:29 AM