This is an archive of the discontinued LLVM Phabricator instance.

Differential D159130

[CMake] Add option to disable driver build in Fuchsia cache file
ClosedPublic

Authored by abrachet on Aug 29 2023, 11:27 AM.

Details

Reviewers
phosek
Commits
rGc7cc756ce343: [CMake] Add option to disable driver build in Fuchsia cache file
Summary

Linking the driver binary can take a long time, particularly with debug
info. This adds an option to disable the driver build meant for local use.

Diff Detail

Event Timeline

abrachet created this revision.Aug 29 2023, 11:27 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 29 2023, 11:27 AM
Herald added a subscriber: ekilmer. · View Herald Transcript
abrachet requested review of this revision.Aug 29 2023, 11:27 AM
phosek added inline comments.Aug 29 2023, 11:51 AM
clang/cmake/caches/Fuchsia-stage2.cmake
34–37

Nit: can you use ON for consistency?

phosek accepted this revision.Aug 29 2023, 11:52 AM

LGTM

This revision is now accepted and ready to land.Aug 29 2023, 11:52 AM
Harbormaster completed remote builds in B255597: Diff 554443.Aug 29 2023, 4:09 PM
This revision was landed with ongoing or failed builds.Sep 5 2023, 8:23 AM
Closed by commit rGc7cc756ce343: [CMake] Add option to disable driver build in Fuchsia cache file (authored by abrachet). · Explain Why
This revision was automatically updated to reflect the committed changes.
abrachet marked an inline comment as done.
abrachet added a commit: rGc7cc756ce343: [CMake] Add option to disable driver build in Fuchsia cache file.
Herald added a project: Restricted Project. · View Herald TranscriptSep 5 2023, 8:23 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
abrachet added inline comments.Sep 5 2023, 8:23 AM
clang/cmake/caches/Fuchsia-stage2.cmake
34–37

Done in commit

Revision Contents

PathSize
clang/
cmake/
caches/
5 lines

Diff 555869

clang/cmake/caches/Fuchsia-stage2.cmake

Show All 25 Lines
set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "") set(LLVM_INCLUDE_EXAMPLES OFF CACHE BOOL "")
set(LLVM_STATIC_LINK_CXX_STDLIB ON CACHE BOOL "") set(LLVM_STATIC_LINK_CXX_STDLIB ON CACHE BOOL "")
set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "") set(LLVM_USE_RELATIVE_PATHS_IN_FILES ON CACHE BOOL "")
set(LLDB_ENABLE_CURSES OFF CACHE BOOL "") set(LLDB_ENABLE_CURSES OFF CACHE BOOL "")
set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "") set(LLDB_ENABLE_LIBEDIT OFF CACHE BOOL "")
if(WIN32) if(WIN32)
set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "") set(LLVM_USE_CRT_RELEASE "MT" CACHE STRING "")
else() set(FUCHSIA_DISABLE_DRIVER_BUILD ON)
endif()
if (NOT FUCHSIA_DISABLE_DRIVER_BUILD)
phosekUnsubmitted
Done
ReplyInline Actions

Nit: can you use ON for consistency?

phosek: Nit: can you use `ON` for consistency?
abrachetAuthorUnsubmitted
Done
ReplyInline Actions

Done in commit

abrachet: Done in commit
set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "") set(LLVM_TOOL_LLVM_DRIVER_BUILD ON CACHE BOOL "")
set(LLVM_DRIVER_TARGET llvm-driver) set(LLVM_DRIVER_TARGET llvm-driver)
endif() endif()
set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "") set(CLANG_DEFAULT_CXX_STDLIB libc++ CACHE STRING "")
set(CLANG_DEFAULT_LINKER lld CACHE STRING "") set(CLANG_DEFAULT_LINKER lld CACHE STRING "")
set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "") set(CLANG_DEFAULT_OBJCOPY llvm-objcopy CACHE STRING "")
set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "") set(CLANG_DEFAULT_RTLIB compiler-rt CACHE STRING "")
▲ Show 20 Lines • Show All 329 Lines • Show Last 20 Lines