[libc++]Declaring '__asign_view__' as a non noexcept function

[Ris-Bali]

Summary

__assign_view__ is declared as a noexcept function in libcxx/include/__filesystem/path.h however internally it calls std::basic_string<char>::basic_string<char>(std::string_view) which is not a noexcept function this may lead to a std::terminate() call when allocation of a new string fails.

Fixes : https://github.com/llvm/llvm-project/issues/64858

[Mordante]

Thanks for your contribution, LGTM!

FYI @cor3ntin works on Clang not on libc++.

Can you update the commit message with a link to the bug fixed?

If you want somebody to commit this patch on your behalf can you provide your name and e-mail address?

[Ris-Bali]

Name: Rishabh Bali
email: [e-mail]
Github username: Ris-Bali

Thanks.

libcxx/include/__filesystem/path.h

operator>>(basic_istream<_CharT, _Traits>& __is, path& __p) {
     basic_string<_CharT, _Traits> __tmp;
     __is >> _VSTD::__quoted(__tmp);
     __p = __tmp;
     return __is;
   }
 #endif // !_LIBCPP_HAS_NO_LOCALIZATION
 
 private:
-  inline _LIBCPP_HIDE_FROM_ABI path&
-  __assign_view(__string_view const& __s) noexcept {
+  inline _LIBCPP_HIDE_FROM_ABI path& __assign_view(__string_view const& __s) {
     __pn_ = string_type(__s);
     return *this;
   }
   string_type __pn_;
 };
 
 inline _LIBCPP_HIDE_FROM_ABI void swap(path& __lhs, path& __rhs) noexcept {
   __lhs.swap(__rhs);