This is an archive of the discontinued LLVM Phabricator instance.

[clang] Fix the pre-commit CI pipeline after changes to libc++'s own CI pipeline
ClosedPublic

Authored by ldionne on Aug 23 2023, 6:45 PM.

Details

Summary

We made some changes to the libc++ CI pipeline that take for granted
that we're running on libc++'s own Docker images. This was necessary for
a temporary period until widely-used tools update to a version that can
handle C++20 modules.

However, this had the unintended consequence of breaking the Clang CI
pipeline, which used the libc++ CI scripts as an implementation detail.
Instead, decouple the Clang CI pipeline from the libc++ build scripts.

Diff Detail

Event Timeline

ldionne created this revision.Aug 23 2023, 6:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 6:45 PM
ldionne requested review of this revision.Aug 23 2023, 6:45 PM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 6:45 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ldionne added a reviewer: Restricted Project.Aug 23 2023, 6:45 PM
ldionne accepted this revision.Aug 23 2023, 7:21 PM

Along with aa60b2687ce3b67e454ba7c8c58a8688247df0b8, this will make the Clang CI green again. We'll figure out what's the underlying cause for aa60b2687ce3b67e454ba7c8c58a8688247df0b8 tomorrow, it's too late for today.

This revision is now accepted and ready to land.Aug 23 2023, 7:21 PM
This revision was landed with ongoing or failed builds.Aug 23 2023, 7:22 PM
This revision was automatically updated to reflect the committed changes.

The follow-up to the temporary workaround is going to be done tomorrow in D158694.