This is an archive of the discontinued LLVM Phabricator instance.

[libc++][modules] Adds std.compat module files.
AbandonedPublic

Authored by Mordante on Aug 23 2023, 10:22 AM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

This adds the files with the named declarations in the global namespace
used in the std.compat module. Using these files and testing them will
be done in a followup commit.

Implements parts of

  • P2465R3 Standard Library Modules std and std.compat

Diff Detail

Event Timeline

Mordante created this revision.Aug 23 2023, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 10:22 AM
Mordante requested review of this revision.Aug 23 2023, 10:22 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 23 2023, 10:22 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne added a subscriber: ldionne.Sep 6 2023, 8:40 AM

I think it would be better to have the tests ready when we ship this patch. Otherwise we risk having to make major changes to these .inc files (e.g. _LIBCPP_USING_IF_EXISTS). We could probably start over on GitHub.

Mordante abandoned this revision.Sep 6 2023, 10:37 AM

I think it would be better to have the tests ready when we ship this patch. Otherwise we risk having to make major changes to these .inc files (e.g. _LIBCPP_USING_IF_EXISTS). We could probably start over on GitHub.

This will be quite some work and since we're trying to clear the Phabricator review queue I'll abandon this. Once I have a complete patch I'll create a GitHub PR.