This is an archive of the discontinued LLVM Phabricator instance.

Differential D158599

[NFC][Flang][Driver] Refactor R_Group options tests
ClosedPublic

Authored by victorkingi on Aug 23 2023, 5:20 AM.

Details

Reviewers
awarzynski
Commits
rG1b1092016469: [NFC][Flang][Driver] Refactor R_Group options tests
Summary

This commit addresses the comment at
https://reviews.llvm.org/D158174#inline-1534036 which
suggested adding a check for un-inlined remarks
printed.

Diff Detail

Event Timeline

victorkingi created this revision.Aug 23 2023, 5:20 AM
Herald added a reviewer: awarzynski. · View Herald TranscriptAug 23 2023, 5:20 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald Transcript
victorkingi requested review of this revision.Aug 23 2023, 5:20 AM
Herald added subscribers: wangpc, jdoerfert. · View Herald TranscriptAug 23 2023, 5:20 AM
victorkingi mentioned this in D158174: [Flang][Driver] Implement OPT_R_Joined options.Aug 23 2023, 5:21 AM
Harbormaster completed remote builds in B254307: Diff 552667.Aug 23 2023, 5:43 AM
awarzynski accepted this revision.Aug 23 2023, 6:25 AM

LGTM, thank you!

This revision is now accepted and ready to land.Aug 23 2023, 6:25 AM
Closed by commit rG1b1092016469: [NFC][Flang][Driver] Refactor R_Group options tests (authored by Victor Kingi <victor.kingi@arm.com>). · Explain WhyAug 23 2023, 8:10 AM
This revision was automatically updated to reflect the committed changes.
Victor Kingi <victor.kingi@arm.com> added a commit: rG1b1092016469: [NFC][Flang][Driver] Refactor R_Group options tests.

Revision Contents

PathSize
flang/
test/
Driver/
5 lines

Diff 552720

flang/test/Driver/optimization-remark.f90

Show All 15 Lines
! Check full -Rpass-missed message is emitted ! Check full -Rpass-missed message is emitted
! RUN: %flang %s -O1 -Rpass-missed 2>&1 | FileCheck %s --check-prefix=REMARKS-MISSED ! RUN: %flang %s -O1 -Rpass-missed 2>&1 | FileCheck %s --check-prefix=REMARKS-MISSED
! Check full -Rpass-analysis message is emitted ! Check full -Rpass-analysis message is emitted
! RUN: %flang %s -O1 -Rpass-analysis 2>&1 | FileCheck %s --check-prefix=REMARKS-ANALYSIS ! RUN: %flang %s -O1 -Rpass-analysis 2>&1 | FileCheck %s --check-prefix=REMARKS-ANALYSIS
! CHECK: remark: Loop deleted because it is invariant ! CHECK: remark: Loop deleted because it is invariant
! REMARKS-MISSED: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
! REMARKS-MISSED: remark: loop not vectorized ! REMARKS-MISSED: remark: loop not vectorized
! REMARKS-MISSED-NOT: instruction cannot be vectorized ! REMARKS-MISSED-NOT: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized ! REMARKS-ANALYSIS: remark: loop not vectorized: instruction cannot be vectorized
! REMARKS-ANALYSIS-NOT: will not be inlined into {{.*}} because its definition is unavailable ! REMARKS-ANALYSIS-NOT: {{.*}} will not be inlined into {{.*}} because its definition is unavailable
! REMARKS: remark: ! REMARKS: remark:
! NO-REMARKS-NOT: remark: ! NO-REMARKS-NOT: remark:
program forttest program forttest
implicit none implicit none
real, dimension(1:50) :: aR1 real, dimension(1:50) :: aR1
integer :: n integer :: n
Show All 11 Lines