We can use r11 scratch registers for calculations.
It does not result in any performance improvements, as the spill is on
the slow path of partial granules.
See X86AsmPrinter::LowerASAN_CHECK_MEMACCESS for callers.
Paths
| Differential D158525
[asan] Remove unnecessary spill in optimized callbacks ClosedPublic Authored by vitalybuka on Aug 22 2023, 9:35 AM.
Details Summary We can use r11 scratch registers for calculations. It does not result in any performance improvements, as the spill is on See X86AsmPrinter::LowerASAN_CHECK_MEMACCESS for callers.
Diff Detail
Event Timelinevitalybuka retitled this revision from [asan] Remove unnececeary spill in optimized callbacks to [asan] Remove unnecessary spill in optimized callbacks.Aug 22 2023, 9:39 AM This revision is now accepted and ready to land.Aug 23 2023, 3:02 PM Closed by commit rG9ddb2157e3c0: [asan] Remove unnecessary spill in optimized callbacks (authored by vitalybuka). · Explain WhyAug 23 2023, 5:00 PM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 552926 compiler-rt/lib/asan/asan_rtl_x86_64.S
|