This is an archive of the discontinued LLVM Phabricator instance.

[asan] Remove unnecessary spill in optimized callbacks
ClosedPublic

Authored by vitalybuka on Aug 22 2023, 9:35 AM.

Details

Summary

We can use r11 scratch registers for calculations.

It does not result in any performance improvements, as the spill is on
the slow path of partial granules.

See X86AsmPrinter::LowerASAN_CHECK_MEMACCESS for callers.

Diff Detail

Event Timeline

vitalybuka created this revision.Aug 22 2023, 9:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 9:35 AM
Herald added a subscriber: Enna1. · View Herald Transcript
vitalybuka requested review of this revision.Aug 22 2023, 9:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptAug 22 2023, 9:35 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
vitalybuka edited the summary of this revision. (Show Details)Aug 22 2023, 9:36 AM
vitalybuka added a reviewer: kstoimenov.
vitalybuka retitled this revision from [asan] Remove unnececeary spill in optimized callbacks to [asan] Remove unnecessary spill in optimized callbacks.Aug 22 2023, 9:39 AM
kstoimenov accepted this revision.Aug 23 2023, 3:02 PM
This revision is now accepted and ready to land.Aug 23 2023, 3:02 PM
This revision was automatically updated to reflect the committed changes.