Page MenuHomePhabricator

[WinEH] Tighten parentPad verifier checks
ClosedPublic

Authored by JosephTremoulet on Jan 1 2016, 5:25 PM.

Details

Summary

A catchswitch cannot be a parent of a cleanuppad or another catchswitch.

Diff Detail

Event Timeline

JosephTremoulet retitled this revision from to [WinEH] Tighten parentPad verifier checks.
JosephTremoulet updated this object.
JosephTremoulet added a subscriber: llvm-commits.
majnemer accepted this revision.Jan 1 2016, 11:20 PM
majnemer edited edge metadata.

LGTM

lib/IR/Verifier.cpp
3022–3023

I guess we can simplify this by writing it as isa<ConstantTokenNone>(ParentPad) || isa<FuncletEHPadInst>(ParentPad).

3079–3080

Ditto.

This revision is now accepted and ready to land.Jan 1 2016, 11:20 PM
JosephTremoulet edited edge metadata.

address feedback