Page MenuHomePhabricator

AMDGPU: Avoid assertions after SGPR spilling failed
ClosedPublic

Authored by nhaehnle on Dec 30 2015, 9:17 AM.

Details

Summary

The comment explains it: emitError does not necessarily exit the compilation
process, and then using NoRegister leads to assertions later on.
This generates incorrect code, of course, but the user should know to not use
the result when an error has been emitted.

It would be nice to have a test-case for this inside the LLVM repository,
but llc exits on error. shader-db tests trigger the underlying issue at least
on Tonga.

Diff Detail

Repository
rL LLVM

Event Timeline

nhaehnle updated this revision to Diff 43791.Dec 30 2015, 9:17 AM
nhaehnle retitled this revision from to AMDGPU: Avoid assertions after SGPR spilling failed.
nhaehnle updated this object.
nhaehnle added a subscriber: llvm-commits.
tstellarAMD accepted this revision.Jan 4 2016, 6:46 AM
tstellarAMD edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Jan 4 2016, 6:46 AM
This revision was automatically updated to reflect the committed changes.