This is an archive of the discontinued LLVM Phabricator instance.

Differential D158211

[flang][openacc][NFC] Remove Todo test for acc declare
ClosedPublic

Authored by clementval on Aug 17 2023, 1:35 PM.

Details

Reviewers
razvanlupusoru
vzakhari
Commits
rGb26f83cba7e2: [flang][openacc][NFC] Remove Todo test for acc declare
Summary

Remove this test as the message is not triggered anymore. No idea
why this test is not failing upstream.

Diff Detail

Event Timeline

clementval created this revision.Aug 17 2023, 1:35 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptAug 17 2023, 1:35 PM
clementval requested review of this revision.Aug 17 2023, 1:35 PM
Herald added a subscriber: jdoerfert. · View Herald TranscriptAug 17 2023, 1:35 PM
razvanlupusoru accepted this revision.Aug 17 2023, 1:37 PM
This revision is now accepted and ready to land.Aug 17 2023, 1:37 PM
This revision was landed with ongoing or failed builds.Aug 17 2023, 2:01 PM
Closed by commit rGb26f83cba7e2: [flang][openacc][NFC] Remove Todo test for acc declare (authored by clementval). · Explain Why
This revision was automatically updated to reflect the committed changes.
clementval added a commit: rGb26f83cba7e2: [flang][openacc][NFC] Remove Todo test for acc declare.
Harbormaster completed remote builds in B253297: Diff 551248.Aug 17 2023, 2:19 PM

Revision Contents

PathSize
flang/
test/
Lower/
OpenACC/
Todo/

Diff 551258

flang/test/Lower/OpenACC/Todo/acc-declare.f90

  • This file was deleted.
! This test checks lowering of OpenACC declare Directive.
// RUN: not flang-new -fc1 -emit-fir -fopenacc %s 2>&1 | FileCheck %s
program main
real, dimension(10) :: aa, bb
// CHECK: not yet implemented: OpenACC Standalone Declarative construct
!$acc declare present(aa, bb)
end