[lldb] Remove {Get,Set}CloseInputOnEOF and deprecate SB equivalent (NFC)

[JDevlieghere]

Summary

These functions have been NO-OPs since 2014 (44d937820b451). Remove them
and deprecate the corresponding functions in SBDebugger.

[bulbazord]

lldb/source/API/SBDebugger.cpp

1538–1545

You probably want these annotations on the header file so that projects that compile against LLDB get the deprecation warnings.

[JDevlieghere]

lldb/source/API/SBDebugger.cpp

1538–1545

Good point. Fixed in f2ec73c74650.

lldb/include/lldb/Core/Debugger.h

public:
   llvm::StringRef GetTopIOHandlerControlSequence(char ch);
 
   const char *GetIOHandlerCommandPrefix();
 
   const char *GetIOHandlerHelpPrologue();
 
   void ClearIOHandlers();
 
-  bool GetCloseInputOnEOF() const;
-
-  void SetCloseInputOnEOF(bool b);
-
   bool EnableLog(llvm::StringRef channel,
                  llvm::ArrayRef<const char *> categories,
                  llvm::StringRef log_file, uint32_t log_options,
                  size_t buffer_size, LogHandlerKind log_handler_kind,
                  llvm::raw_ostream &error_stream);
 
   void SetLoggingCallback(lldb::LogOutputCallback log_callback, void *baton);
 

lldb/source/API/SBDebugger.cpp

bool SBDebugger::SetCurrentPlatformSDKRoot(const char *sysroot) {
 
   if (SBPlatform platform = GetSelectedPlatform()) {
     platform.SetSDKRoot(sysroot);
     return true;
   }
   return false;
 }
 
+LLDB_DEPRECATED("SBDebugger::GetCloseInputOnEOF() is deprecated.")
 bool SBDebugger::GetCloseInputOnEOF() const {
   LLDB_INSTRUMENT_VA(this);
 
-  return (m_opaque_sp ? m_opaque_sp->GetCloseInputOnEOF() : false);
+  return false;
 }
 
+LLDB_DEPRECATED("SBDebugger::SetCloseInputOnEOF() is deprecated.")
 void SBDebugger::SetCloseInputOnEOF(bool b) {
   LLDB_INSTRUMENT_VA(this, b);
-
-  if (m_opaque_sp)
-    m_opaque_sp->SetCloseInputOnEOF(b);
 }
 
 SBTypeCategory SBDebugger::GetCategory(const char *category_name) {
   LLDB_INSTRUMENT_VA(this, category_name);
 
   if (!category_name || *category_name == 0)
     return SBTypeCategory();
 

lldb/source/Core/Debugger.cpp

llvm::call_once(m_clear_once, [this]() {
 
     m_command_interpreter_up->Clear();
 
     if (Diagnostics::Enabled())
       Diagnostics::Instance().RemoveCallback(m_diagnostics_callback_id);
   });
 }
 
-bool Debugger::GetCloseInputOnEOF() const {
-  //    return m_input_comm.GetCloseOnEOF();
-  return false;
-}
-
-void Debugger::SetCloseInputOnEOF(bool b) {
-  //    m_input_comm.SetCloseOnEOF(b);
-}
-
 bool Debugger::GetAsyncExecution() {
   return !m_command_interpreter_up->GetSynchronous();
 }
 
 void Debugger::SetAsyncExecution(bool async_execution) {
   m_command_interpreter_up->SetSynchronous(!async_execution);
 }