Page MenuHomePhabricator

[ms inline asm] Add support for label names with '$' chars
ClosedPublic

Authored by myatsina on Dec 28 2015, 7:41 AM.

Details

Summary

In MS inline asm syntax a label with '$' char produces an error, while in AT&T it does not.
In AT&T inline asm syntax Clang escapes the '$' char and replaces it with "$$". Adopted same approach for MS syntax.

Diff Detail

Repository
rL LLVM

Event Timeline

myatsina updated this revision to Diff 43692.Dec 28 2015, 7:41 AM
myatsina retitled this revision from to [ms inline asm] Add support for label names with '$' chars.
myatsina updated this object.
myatsina added reviewers: ehsan, rnk.
myatsina set the repository for this revision to rL LLVM.
myatsina added subscribers: llvm-commits, cfe-commits.
ehsan accepted this revision.Dec 28 2015, 8:20 AM
ehsan edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Dec 28 2015, 8:20 AM
This revision was automatically updated to reflect the committed changes.